Message id access#13
Closed
ramontayag wants to merge 13 commits into
Closed
Conversation
Fixes errors with missing SecureRandom
houndci-bot
reviewed
Apr 25, 2018
houndci-bot
left a comment
houndci-bot
left a comment
There was a problem hiding this comment.
Some files could not be reviewed due to errors:
.rubocop.yml: Style/DotPosition has the wrong namespace - should be Layout
.rubocop.yml: Style/DotPosition has the wrong namespace - should be Layout .rubocop.yml: Style/IndentHash has the wrong namespace - should be Layout Error: The `Style/TrailingComma` cop no longer exists. Please use `Style/TrailingCommaInArguments`, `Style/TrailingCommaInArrayLiteral`, and/or `Style/TrailingCommaInHashLiteral` instead. (obsolete configuration found in .rubocop.yml, please update it) The `Lint/InvalidCharacterLiteral` cop has been removed since it was never being actually triggered. The `Style/DeprecatedHashMethods` cop has been renamed to `Style/PreferredHashMethods`. The `Style/OpMethod` cop has been renamed and moved to `Naming/BinaryOperatorParameterName`.
Let's not check coverage yet while we make a fork of message_bus-client
Remove coverage check
Run tests against Ruby 2.4.1 and 2.5.0
The problem of the puma process living beyond the command that started it is confirmed on MacOS. This code may break things on Windows.
Fix teardown of puma server
This is not tested. There doesn't seem to be a way to test this without being able to reset the channel messages
Be able to customize set `last_id`
ramontayag
force-pushed
the
message_id_access
branch
from
6751d17 to
24cc932
Compare
houndci-bot
reviewed
Jul 9, 2018
houndci-bot
left a comment
houndci-bot
left a comment
There was a problem hiding this comment.
Some files could not be reviewed due to errors:
.rubocop.yml: Style/DotPosition has the wrong namespace - should be Layout
.rubocop.yml: Style/DotPosition has the wrong namespace - should be Layout .rubocop.yml: Style/IndentHash has the wrong namespace - should be Layout Error: The `Style/TrailingComma` cop no longer exists. Please use `Style/TrailingCommaInArguments`, `Style/TrailingCommaInArrayLiteral`, and/or `Style/TrailingCommaInHashLiteral` instead. (obsolete configuration found in .rubocop.yml, please update it) The `Lint/InvalidCharacterLiteral` cop has been removed since it was never being actually triggered. The `Style/DeprecatedHashMethods` cop has been renamed to `Style/PreferredHashMethods`. The `Style/OpMethod` cop has been renamed and moved to `Naming/BinaryOperatorParameterName`.
ramontayag
force-pushed
the
message_id_access
branch
from
24cc932 to
340c6a4
Compare
houndci-bot
reviewed
Jul 9, 2018
houndci-bot
left a comment
houndci-bot
left a comment
There was a problem hiding this comment.
Some files could not be reviewed due to errors:
.rubocop.yml: Style/DotPosition has the wrong namespace - should be Layout
.rubocop.yml: Style/DotPosition has the wrong namespace - should be Layout .rubocop.yml: Style/IndentHash has the wrong namespace - should be Layout Error: The `Style/TrailingComma` cop no longer exists. Please use `Style/TrailingCommaInArguments`, `Style/TrailingCommaInArrayLiteral`, and/or `Style/TrailingCommaInHashLiteral` instead. (obsolete configuration found in .rubocop.yml, please update it) The `Lint/InvalidCharacterLiteral` cop has been removed since it was never being actually triggered. The `Style/DeprecatedHashMethods` cop has been renamed to `Style/PreferredHashMethods`. The `Style/OpMethod` cop has been renamed and moved to `Naming/BinaryOperatorParameterName`.
ramontayag
force-pushed
the
message_id_access
branch
from
340c6a4 to
9204dd4
Compare
houndci-bot
reviewed
Jul 9, 2018
houndci-bot
left a comment
houndci-bot
left a comment
There was a problem hiding this comment.
Some files could not be reviewed due to errors:
.rubocop.yml: Style/DotPosition has the wrong namespace - should be Layout
.rubocop.yml: Style/DotPosition has the wrong namespace - should be Layout .rubocop.yml: Style/IndentHash has the wrong namespace - should be Layout Error: The `Style/TrailingComma` cop no longer exists. Please use `Style/TrailingCommaInArguments`, `Style/TrailingCommaInArrayLiteral`, and/or `Style/TrailingCommaInHashLiteral` instead. (obsolete configuration found in .rubocop.yml, please update it) The `Lint/InvalidCharacterLiteral` cop has been removed since it was never being actually triggered. The `Style/DeprecatedHashMethods` cop has been renamed to `Style/PreferredHashMethods`. The `Style/OpMethod` cop has been renamed and moved to `Naming/BinaryOperatorParameterName`.
houndci-bot
reviewed
Jul 9, 2018
houndci-bot
left a comment
houndci-bot
left a comment
There was a problem hiding this comment.
Some files could not be reviewed due to errors:
.rubocop.yml: Style/DotPosition has the wrong namespace - should be Layout
.rubocop.yml: Style/DotPosition has the wrong namespace - should be Layout .rubocop.yml: Style/IndentHash has the wrong namespace - should be Layout Error: The `Style/TrailingComma` cop no longer exists. Please use `Style/TrailingCommaInArguments`, `Style/TrailingCommaInArrayLiteral`, and/or `Style/TrailingCommaInHashLiteral` instead. (obsolete configuration found in .rubocop.yml, please update it) The `Lint/InvalidCharacterLiteral` cop has been removed since it was never being actually triggered. The `Style/DeprecatedHashMethods` cop has been renamed to `Style/PreferredHashMethods`. The `Style/OpMethod` cop has been renamed and moved to `Naming/BinaryOperatorParameterName`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requires:
Add ability to access
message_idif specified in the callback