Skip to content

Add last_id in NotifyTxReceipt data params#37

Merged
iamajvillalobos merged 1 commit into
masterfrom
last-id-in-notification-params-156982468
Apr 24, 2018
Merged

Add last_id in NotifyTxReceipt data params#37
iamajvillalobos merged 1 commit into
masterfrom
last-id-in-notification-params-156982468

Conversation

@iamajvillalobos

Copy link
Copy Markdown
Contributor

No description provided.

@MarkFChavez MarkFChavez left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@iamajvillalobos iamajvillalobos merged commit a4de1d5 into master Apr 24, 2018
@iamajvillalobos iamajvillalobos deleted the last-id-in-notification-params-156982468 branch April 24, 2018 04:14
@ramontayag

Copy link
Copy Markdown
Collaborator

Hey guys, I'd like to avoid this one. We should look at exposing this information in MessageBus::Client since MessageBus already sends it to the subscribers:

postman

The problem with shoe horning it into the data field this way is that because of the multi-threaded nature of MessageBus, we're not sure the last_id is actually the id of the message that is being sent over. Although the number won't be far, it could be potentially be misleading.

@iamajvillalobos

iamajvillalobos commented Apr 24, 2018

Copy link
Copy Markdown
Contributor Author

Sorry @ramontayag. This is weird, because I'm not getting this format when I do the subscription.
screen shot 2018-04-24 at 9 09 12 pm

Don't mind the last_id attribute in params, it's from this PR.

@ramontayag

Copy link
Copy Markdown
Collaborator

Yes, that's because MessageBus::Client is not exposing it to you. Here I made some changes: lowjoel/message_bus-client#13

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants