Custom last ID#12
Open
ramontayag wants to merge 11 commits into
Open
Conversation
Fixes errors with missing SecureRandom
houndci-bot
reviewed
Apr 22, 2018
houndci-bot
left a comment
houndci-bot
left a comment
There was a problem hiding this comment.
Some files could not be reviewed due to errors:
.rubocop.yml: Style/DotPosition has the wrong namespace - should be Layout
.rubocop.yml: Style/DotPosition has the wrong namespace - should be Layout .rubocop.yml: Style/IndentHash has the wrong namespace - should be Layout Error: The `Style/TrailingComma` cop no longer exists. Please use `Style/TrailingCommaInArguments`, `Style/TrailingCommaInArrayLiteral`, and/or `Style/TrailingCommaInHashLiteral` instead. (obsolete configuration found in .rubocop.yml, please update it) The `Lint/InvalidCharacterLiteral` cop has been removed since it was never being actually triggered. The `Style/DeprecatedHashMethods` cop has been renamed to `Style/PreferredHashMethods`. The `Style/OpMethod` cop has been renamed and moved to `Naming/BinaryOperatorParameterName`.
Let's not check coverage yet while we make a fork of message_bus-client
Remove coverage check
Run tests against Ruby 2.4.1 and 2.5.0
The problem of the puma process living beyond the command that started it is confirmed on MacOS. This code may break things on Windows.
Fix teardown of puma server
ramontayag
force-pushed
the
custom_last_id
branch
from
d443aa6 to
0bf2ed3
Compare
houndci-bot
reviewed
Jul 9, 2018
houndci-bot
left a comment
houndci-bot
left a comment
There was a problem hiding this comment.
Some files could not be reviewed due to errors:
.rubocop.yml: Style/DotPosition has the wrong namespace - should be Layout
.rubocop.yml: Style/DotPosition has the wrong namespace - should be Layout .rubocop.yml: Style/IndentHash has the wrong namespace - should be Layout Error: The `Style/TrailingComma` cop no longer exists. Please use `Style/TrailingCommaInArguments`, `Style/TrailingCommaInArrayLiteral`, and/or `Style/TrailingCommaInHashLiteral` instead. (obsolete configuration found in .rubocop.yml, please update it) The `Lint/InvalidCharacterLiteral` cop has been removed since it was never being actually triggered. The `Style/DeprecatedHashMethods` cop has been renamed to `Style/PreferredHashMethods`. The `Style/OpMethod` cop has been renamed and moved to `Naming/BinaryOperatorParameterName`.
ramontayag
force-pushed
the
custom_last_id
branch
from
0bf2ed3 to
f52bb8f
Compare
houndci-bot
reviewed
Jul 9, 2018
houndci-bot
left a comment
houndci-bot
left a comment
There was a problem hiding this comment.
Some files could not be reviewed due to errors:
.rubocop.yml: Style/DotPosition has the wrong namespace - should be Layout
.rubocop.yml: Style/DotPosition has the wrong namespace - should be Layout .rubocop.yml: Style/IndentHash has the wrong namespace - should be Layout Error: The `Style/TrailingComma` cop no longer exists. Please use `Style/TrailingCommaInArguments`, `Style/TrailingCommaInArrayLiteral`, and/or `Style/TrailingCommaInHashLiteral` instead. (obsolete configuration found in .rubocop.yml, please update it) The `Lint/InvalidCharacterLiteral` cop has been removed since it was never being actually triggered. The `Style/DeprecatedHashMethods` cop has been renamed to `Style/PreferredHashMethods`. The `Style/OpMethod` cop has been renamed and moved to `Naming/BinaryOperatorParameterName`.
This is not tested. There doesn't seem to be a way to test this without being able to reset the channel messages
ramontayag
force-pushed
the
custom_last_id
branch
from
f52bb8f to
5815817
Compare
houndci-bot
reviewed
Jul 9, 2018
houndci-bot
left a comment
houndci-bot
left a comment
There was a problem hiding this comment.
Some files could not be reviewed due to errors:
.rubocop.yml: Style/DotPosition has the wrong namespace - should be Layout
.rubocop.yml: Style/DotPosition has the wrong namespace - should be Layout .rubocop.yml: Style/IndentHash has the wrong namespace - should be Layout Error: The `Style/TrailingComma` cop no longer exists. Please use `Style/TrailingCommaInArguments`, `Style/TrailingCommaInArrayLiteral`, and/or `Style/TrailingCommaInHashLiteral` instead. (obsolete configuration found in .rubocop.yml, please update it) The `Lint/InvalidCharacterLiteral` cop has been removed since it was never being actually triggered. The `Style/DeprecatedHashMethods` cop has been renamed to `Style/PreferredHashMethods`. The `Style/OpMethod` cop has been renamed and moved to `Naming/BinaryOperatorParameterName`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requires:
This is not tested. There doesn't seem to be a way to test this without being able to reset the channel messages. Some possible ways to test this: