Add Class to Measure IVU Impedance - #330
Open
fernandohds564 wants to merge 7 commits into
Open
Conversation
…rom MeasIVUImpedance class.
fernandohds564
requested review from
Gabrielrezende-asc,
HenriqueWS11,
VitorSouzaLNLS,
anacso17,
vellosok75 and
xresende
August 18, 2026 19:10
HenriqueWS11
approved these changes
Aug 18, 2026
vellosok75
reviewed
Aug 20, 2026
Comment on lines
+242
to
+244
| b1_offset = 50 | ||
| windowp = 20 | ||
| windown = -10 |
Contributor
There was a problem hiding this comment.
I'd suggest adding some documentation on how these numbers were determined. Perhaps reference the initial tests and measurments notebook.
vellosok75
approved these changes
Aug 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add class to acquire BPM data at ADCSwap rate and process signals of two bunches well separated in the ring. This class was used to measure impedance of storage ring components, such as IVU's.