Select which BPMs to control in AcqBPMsSignals. - #331
Open
fernandohds564 wants to merge 1 commit into
Open
Conversation
fernandohds564
requested review from
Gabrielrezende-asc,
HenriqueWS11,
JeffersonBarrosVieira,
VitorSouzaLNLS,
anacso17,
vellosok75 and
xresende
August 18, 2026 19:17
HenriqueWS11
approved these changes
Aug 18, 2026
JeffersonBarrosVieira
approved these changes
Aug 18, 2026
VitorSouzaLNLS
approved these changes
Aug 19, 2026
vellosok75
approved these changes
Aug 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the functionality of selecting which BPMs will be controlled during triggered acquisitions.
This feature proved very useful in acquisitions at ADCSwap rate, during measurements of the IVU impedance (see #330), where the data acquisition rate is very high, which compromises the integrity of the acquisitions with all BPMs. By splitting the BPMs in two groups, odd and even, we were able to increase the number of acquisition points from 1910 to 191000 without running into any halt and/or data integrity issues.