[Vulkan] Use the uniform texel buffer type for Buffer SRV#1041
Open
[Vulkan] Use the uniform texel buffer type for Buffer SRV#1041
Conversation
We were setting VK_DESCRIPTOR_TYPE_STORAGE_TEXEL_BUFFER for the `Buffer` type, but for SRVs we need VK_DESCRIPTOR_TYPE_UNIFORM_TEXEL_BUFFER here. Fixes llvm#1030
bogner
added
the
test-all
Contributor
|
FYI I merged in the typed buffer PR, so could you also remove the XFAIL from |
This was
linked to
issues
Apr 1, 2026
Contributor
Contributor
manon-traverse
left a comment
manon-traverse
left a comment
There was a problem hiding this comment.
LGTM, this is the correct descriptor type for Buffer.
MarijnS95
reviewed
Apr 2, 2026
Contributor
MarijnS95
left a comment
MarijnS95
left a comment
There was a problem hiding this comment.
Yep that is correct for Buffer which is bound as SRV in DirecyX (but for StructuredBuffer which is also bound as SRV, it remains a STORAGE_BUFFER and not a UNIFORM_BUFFER).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We had
VK_DESCRIPTOR_TYPE_STORAGE_TEXEL_BUFFERfor theBuffertype, but for SRVs we needVK_DESCRIPTOR_TYPE_UNIFORM_TEXEL_BUFFER.Fixes #1030