-
Notifications
You must be signed in to change notification settings - Fork 622
feat: append data with reserved stable row ids #6438
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
6b4739d
e5b03f9
f249375
a6c959f
e248c70
b060aa8
aefbf33
6260083
4f58e10
5a4eff3
bd555c2
4cd5bfa
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -250,7 +250,10 @@ impl FromPyObject<'_> for PyLance<Operation> { | |
| } | ||
| "Append" => { | ||
| let fragments = extract_vec(&ob.getattr("fragments")?)?; | ||
| let op = Operation::Append { fragments }; | ||
| let op = Operation::Append { | ||
| fragments, | ||
| row_ids: None, | ||
| }; | ||
| Ok(Self(op)) | ||
| } | ||
| "Delete" => { | ||
|
|
@@ -403,7 +406,7 @@ impl<'py> IntoPyObject<'py> for PyLance<&Operation> { | |
| .expect("Failed to import LanceOperation namespace"); | ||
|
|
||
| match self.0 { | ||
| Operation::Append { fragments } => { | ||
| Operation::Append { fragments, .. } => { | ||
| let fragments = export_vec(py, fragments.as_slice())?; | ||
|
Comment on lines
408
to
410
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
After introducing Useful? React with 👍 / 👎. |
||
| let cls = namespace | ||
| .getattr("Append") | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This JNI conversion match does not include
Operation::ReserveRowIds; it currently falls through to_ => unimplemented!()inconvert_to_java_operation_inner. As a result, reading transactions from Java (for examplenativeReadTransaction/ transaction listing) will panic when a dataset version was produced byReserveRowIds, causing hard failures instead of a usable Java operation object.Useful? React with 👍 / 👎.