feat: append data with reserved stable row ids#6438
Open
Conversation
Contributor
|
ACTION NEEDED The PR title and description are used as the merge commit message. Please update your PR title and description to match the specification. For details on the error please inspect the "PR Title Check" action. |
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
majin1102
commented
Apr 9, 2026
Contributor
Author
|
@jackye1995 Hi, could you take a look at this issue and PR? If the motivation and proposal make sense to you, I’ll start a vote thread. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close #6466
What this PR does
This PR introduces a new
ReserveRowIdstransaction operation and extendsAppendwith an optionalrow_idsfield. Both changes affect transaction metadata and the serialized transaction schema, so this part needs a vote.What this PR does not do
This PR does not add any new field or persisted state to the manifest. The manifest format remains unchanged. The only manifest-related effect is that this PR provides a controlled transaction-level entry point for reserving and consuming
next_row_id, rather than changing manifest contents themselves.