Skip to content

Add --control-plane-volume-type flag to kops create cluster#17955

Open
Camila-B wants to merge 1 commit intokubernetes:masterfrom
Camila-B:gce/control-plane-volume-type
Open

Add --control-plane-volume-type flag to kops create cluster#17955
Camila-B wants to merge 1 commit intokubernetes:masterfrom
Camila-B:gce/control-plane-volume-type

Conversation

@Camila-B
Copy link
Copy Markdown
Contributor

@Camila-B Camila-B commented Feb 14, 2026

@k8s-ci-robot k8s-ci-robot requested a review from hakman February 14, 2026 04:02
@k8s-ci-robot k8s-ci-robot requested a review from zetaab February 14, 2026 04:02
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 14, 2026
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Feb 14, 2026

Hi @Camila-B. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 14, 2026
@hakman
Copy link
Copy Markdown
Member

hakman commented Feb 14, 2026

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 14, 2026
@Camila-B Camila-B force-pushed the gce/control-plane-volume-type branch 2 times, most recently from 53b9b8a to 50f16fc Compare February 17, 2026 22:31
@Camila-B
Copy link
Copy Markdown
Contributor Author

Camila-B commented Feb 20, 2026

/assign @hakman

@rramkumar1 rramkumar1 mentioned this pull request Apr 2, 2026
Merged
hakman
hakman reviewed Apr 2, 2026
View reviewed changes
pkg/apis/kops/validation/instancegroup.go
allErrs = append(allErrs, field.Invalid(field.NewPath("spec", "warmPool", "minSize"), warmPool.MinSize, "warm pool minSize cannot be negative"))
}
}
//TODO: Add RootVolume validation for other cloud providers ex. GCE
Copy link
Copy Markdown
Member

@hakman hakman Apr 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove changes to the validation from this PR, can be added separately, if needed.

Copy link
Copy Markdown
Member

@justinsb justinsb Apr 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think a TODO is OK, right?

hakman
hakman reviewed Apr 2, 2026
View reviewed changes
cmd/kops/create_cluster.go Outdated
cmd.Flags().Int32Var(&options.NodeVolumeSize, "node-volume-size", options.NodeVolumeSize, "Instance volume size (in GB) for worker nodes")

cmd.Flags().StringVar(&options.ControlPlaneVolumeType, "control-plane-volume-type", options.ControlPlaneVolumeType, "Instance volume type for control-plane nodes")
cmd.RegisterFlagCompletionFunc("control-plane-volume-type", completeStorageType)
Copy link
Copy Markdown
Member

@hakman hakman Apr 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For now, I don't think this does anything.

Copy link
Copy Markdown
Contributor Author

@Camila-B Camila-B Apr 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right. I removed the line

Copy link
Copy Markdown
Member

@hakman hakman Apr 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, please see also the other comment, and I think we can merge this. 🙂

hakman
hakman requested changes Apr 2, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@hakman hakman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a few comments, mostly cleanup. Thanks for the patience.

@Camila-B Camila-B force-pushed the gce/control-plane-volume-type branch from 50f16fc to 3bcc6bc Compare April 2, 2026 17:50
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 3, 2026
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Apr 3, 2026

PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

justinsb
justinsb approved these changes Apr 3, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@justinsb justinsb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 3, 2026
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Apr 3, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: justinsb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 3, 2026
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Apr 3, 2026

@Camila-B: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kops-e2e-k8s-gce-ipalias 3bcc6bc link unknown /test pull-kops-e2e-k8s-gce-ipalias
pull-kops-e2e-k8s-gce-cilium 3bcc6bc link unknown /test pull-kops-e2e-k8s-gce-cilium
pull-kops-e2e-k8s-aws-amazonvpc 3bcc6bc link unknown /test pull-kops-e2e-k8s-aws-amazonvpc
pull-kops-e2e-k8s-aws-calico 3bcc6bc link unknown /test pull-kops-e2e-k8s-aws-calico
pull-kops-build 3bcc6bc link unknown /test pull-kops-build
pull-kops-verify-gofmt 3bcc6bc link unknown /test pull-kops-verify-gofmt
pull-kops-verify-generated 3bcc6bc link unknown /test pull-kops-verify-generated
pull-kops-verify-golangci-lint 3bcc6bc link unknown /test pull-kops-verify-golangci-lint
pull-kops-test 3bcc6bc link unknown /test pull-kops-test
pull-kops-verify-boilerplate 3bcc6bc link unknown /test pull-kops-verify-boilerplate
pull-kops-verify-govet 3bcc6bc link unknown /test pull-kops-verify-govet
pull-kops-verify-gomod 3bcc6bc link unknown /test pull-kops-verify-gomod

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hakman hakman hakman requested changes

@justinsb justinsb justinsb approved these changes

@zetaab zetaab Awaiting requested review from zetaab

Assignees

@justinsb justinsb

@hakman hakman

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/api cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Please add --control-plane-volume-type to kops create cluster

4 participants

@Camila-B @k8s-ci-robot @hakman @justinsb