Skip to content

Add node-volume-type flag to create cluster command#18145

Merged
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
rifelpet:volume-type-flags
Apr 3, 2026
Merged

Add node-volume-type flag to create cluster command#18145
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
rifelpet:volume-type-flags

Conversation

@rifelpet
Copy link
Copy Markdown
Member

@rifelpet rifelpet commented Apr 2, 2026

Closes #17620

@k8s-ci-robot k8s-ci-robot requested review from hakman and zetaab April 2, 2026 00:51
@k8s-ci-robot k8s-ci-robot added area/documentation cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 2, 2026
@rramkumar1
Copy link
Copy Markdown
Contributor

@rifelpet Maybe this PR could just address the node volume type?

#17955 has been out for a while and already address the control plane volume type.

@rifelpet rifelpet force-pushed the volume-type-flags branch from e1bc0aa to 0aa352b Compare April 3, 2026 00:54
@rifelpet rifelpet changed the title Add volume-type flags to create cluster command Add node-volume-type flag to create cluster command Apr 3, 2026
@rifelpet
Copy link
Copy Markdown
Member Author

rifelpet commented Apr 3, 2026

@rifelpet Maybe this PR could just address the node volume type?

#17955 has been out for a while and already address the control plane volume type.

Thanks, I missed that PR. I've updated this to just add the node volume type.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 3, 2026
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hakman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 3, 2026
@k8s-ci-robot k8s-ci-robot merged commit 68fefc5 into kubernetes:master Apr 3, 2026
26 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.36 milestone Apr 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/documentation cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Please add --control-plane-volume-type to kops create cluster

4 participants