Skip to content

[release-1.16] Watch and reconcile operator-controller ConfigMaps#2068

Merged
knative-prow[bot] merged 2 commits intoknative:release-1.16from
knative-prow-robot:cherry-pick-2062-to-release-1.16
Apr 18, 2025
Merged

[release-1.16] Watch and reconcile operator-controller ConfigMaps#2068
knative-prow[bot] merged 2 commits intoknative:release-1.16from
knative-prow-robot:cherry-pick-2062-to-release-1.16

Conversation

@knative-prow-robot
Copy link
Copy Markdown
Contributor

This is an automated cherry-pick of #2062

- Watch and reconcile operator-controller ConfigMaps.
- Reduce memory usage by only watching Knative specific deployments and configmaps.

If users apply configmap changes directly, the operator wasn't
reverting those changes instantly; with this PR, it will watch
applied ConfigMaps and apply `KnativeServing` and `KnativeEventing`
configurations.

Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
@knative-prow-robot knative-prow-robot force-pushed the cherry-pick-2062-to-release-1.16 branch from 6141096 to 424013c Compare April 17, 2025 23:53
@knative-prow knative-prow Bot requested review from houshengbo and matzew April 17, 2025 23:53
@knative-prow knative-prow Bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Apr 17, 2025
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 17, 2025

Codecov Report

Attention: Patch coverage is 0% with 27 lines in your changes missing coverage. Please review.

Project coverage is 62.16%. Comparing base (c4b509a) to head (424013c).
Report is 1 commits behind head on release-1.16.

Files with missing lines Patch % Lines
pkg/reconciler/common/transformers.go 0.00% 9 Missing ⚠️
cmd/operator/main.go 0.00% 6 Missing ⚠️
pkg/reconciler/knativeeventing/controller.go 0.00% 6 Missing ⚠️
pkg/reconciler/knativeserving/controller.go 0.00% 6 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff                @@
##           release-1.16    #2068      +/-   ##
================================================
- Coverage         62.81%   62.16%   -0.66%     
================================================
  Files                49       49              
  Lines              2294     2318      +24     
================================================
  Hits               1441     1441              
- Misses              761      785      +24     
  Partials             92       92              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@houshengbo
Copy link
Copy Markdown
Contributor

/lgtm
/approve

@knative-prow knative-prow Bot added the lgtm Indicates that a PR is ready to be merged. label Apr 18, 2025
@knative-prow
Copy link
Copy Markdown

knative-prow Bot commented Apr 18, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: houshengbo, knative-prow-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 18, 2025
@knative-prow knative-prow Bot merged commit b3f6dcf into knative:release-1.16 Apr 18, 2025
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants