Watch and reconcile operator-controller ConfigMaps#2062
Watch and reconcile operator-controller ConfigMaps#2062knative-prow[bot] merged 2 commits intoknative:mainfrom
Conversation
If users apply configmap changes directly, the operator wasn't reverting those changes instantly; with this PR, it will watch applied ConfigMaps and apply `KnativeServing` and `KnativeEventing` configurations. Signed-off-by: Pierangelo Di Pilato <[email protected]>
knative-prow
Bot
added
the
size/L
![knative-prow[bot]](https://avatars.githubusercontent.com/in/183726?s=60&v=4){kind=small}
There was a problem hiding this comment.
@pierDipi: 3 warnings.
Details
In response to this:
If users apply configmap changes directly, the operator wasn't
reverting those changes instantly; with this PR, it will watch
applied ConfigMaps and applyKnativeServingandKnativeEventing
configurations.In addition, use filtered informers to not watch the entire cluster but only
operator-controller deployments and configmaps.Fixes #
Proposed Changes
- Watch and reconcile operator-controller ConfigMaps instantly
Release Note
Watch and reconcile operator-controller ConfigMaps.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2062 +/- ##
==========================================
- Coverage 62.81% 62.16% -0.66%
==========================================
Files 49 49
Lines 2294 2318 +24
==========================================
Hits 1441 1441
- Misses 761 785 +24
Partials 92 92 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Pierangelo Di Pilato <[email protected]>
|
/cherry-pick release-1.17 |
|
@pierDipi: once the present PR merges, I will cherry-pick it on top of DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/cherry-pick release-1.16 |
|
@pierDipi: once the present PR merges, I will cherry-pick it on top of DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: houshengbo, pierDipi The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow
Bot
added
the
approved
|
@pierDipi: new pull request created: #2063 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@pierDipi: new pull request created: #2064 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/cherry-pick release-1.17 |
|
/cherry-pick release-1.16 |
|
@houshengbo: new pull request created: #2067 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@houshengbo: new pull request created: #2068 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
3 participants
If users apply configmap changes directly, the operator wasn't
reverting those changes instantly; with this PR, it will watch
applied ConfigMaps and apply
KnativeServingandKnativeEventingconfigurations.
In addition, use filtered informers to not watch the entire cluster but only
operator-controller deployments and configmaps.
Proposed Changes
Release Note