-
Notifications
You must be signed in to change notification settings - Fork 0
fix: restore full-featured dashboard, remove landing page sections introduced by #1582 #1583
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,51 +1,149 @@ | ||
| import { ComponentFixture, TestBed } from '@angular/core/testing'; | ||
| import { provideZonelessChangeDetection } from '@angular/core'; | ||
| import { provideRouter } from '@angular/router'; | ||
| import { provideRouter, Router } from '@angular/router'; | ||
| import { provideHttpClient } from '@angular/common/http'; | ||
| import { provideHttpClientTesting, HttpTestingController } from '@angular/common/http/testing'; | ||
| import { NoopAnimationsModule } from '@angular/platform-browser/animations'; | ||
| import { HomeComponent } from './home.component'; | ||
| import { API_BASE_URL } from '../tokens'; | ||
|
|
||
| describe('HomeComponent', () => { | ||
| let fixture: ComponentFixture<HomeComponent>; | ||
| let component: HomeComponent; | ||
| let httpTesting: HttpTestingController; | ||
|
|
||
| /** Flush the initial MetricsStore HTTP requests so signals settle. */ | ||
| function flushPendingRequests(opts: { status?: 'healthy' | 'degraded' | 'down' } = {}): void { | ||
| const status = opts.status ?? 'healthy'; | ||
| httpTesting.match('/api/metrics').forEach(req => | ||
| req.flush({ totalRequests: 100, averageDuration: 45.5, cacheHitRate: 0.85, successRate: 0.98 }), | ||
| ); | ||
| httpTesting.match('/api/health').forEach(req => | ||
| req.flush({ status, version: '1.2.3' }), | ||
| ); | ||
jaypatrick marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| httpTesting.match('/api/queue/stats').forEach(req => | ||
| req.flush({ currentDepth: 3, pending: 2, completed: 50, failed: 1, processingRate: 5, lag: 0, depthHistory: [] }), | ||
| ); | ||
jaypatrick marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| } | ||
|
|
||
| beforeEach(async () => { | ||
| await TestBed.configureTestingModule({ | ||
| imports: [HomeComponent], | ||
| imports: [HomeComponent, NoopAnimationsModule], | ||
| providers: [ | ||
| provideZonelessChangeDetection(), | ||
| provideRouter([]), | ||
| provideHttpClient(), | ||
| provideHttpClientTesting(), | ||
| { provide: API_BASE_URL, useValue: '/api' }, | ||
| ], | ||
| }).compileComponents(); | ||
|
|
||
| fixture = TestBed.createComponent(HomeComponent); | ||
| component = fixture.componentInstance; | ||
| httpTesting = TestBed.inject(HttpTestingController); | ||
|
|
||
| flushPendingRequests(); | ||
| await fixture.whenStable(); | ||
| }); | ||
|
|
||
| afterEach(() => { | ||
| vi.restoreAllMocks(); | ||
| httpTesting.match(() => true).forEach(req => req.flush({})); | ||
jaypatrick marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| httpTesting.verify(); | ||
| }); | ||
|
|
||
| it('should create', () => { | ||
| expect(component).toBeTruthy(); | ||
| }); | ||
|
|
||
| it('should render nav bar', async () => { | ||
| await fixture.whenStable(); | ||
| const nav = fixture.nativeElement.querySelector('app-nav-bar'); | ||
| expect(nav).toBeTruthy(); | ||
| it('should have 6 navigation cards', () => { | ||
| expect(component.navCards.length).toBe(6); | ||
| }); | ||
|
|
||
| it('should render hero section', async () => { | ||
| await fixture.whenStable(); | ||
| const hero = fixture.nativeElement.querySelector('app-hero-section'); | ||
| expect(hero).toBeTruthy(); | ||
| it('should include Compiler card', () => { | ||
| const card = component.navCards.find(c => c.path === '/compiler'); | ||
| expect(card).toBeTruthy(); | ||
| expect(card!.label).toContain('Compiler'); | ||
| }); | ||
|
|
||
| it('should render landing content wrapper', async () => { | ||
| await fixture.whenStable(); | ||
| const wrapper = fixture.nativeElement.querySelector('.landing-content'); | ||
| expect(wrapper).toBeTruthy(); | ||
| it('should include Admin card with warn tag', () => { | ||
| const card = component.navCards.find(c => c.path === '/admin'); | ||
| expect(card).toBeTruthy(); | ||
| expect(card!.tag).toBe('Admin'); | ||
| }); | ||
|
|
||
| it('should derive live stats from metrics', () => { | ||
| const stats = component.liveStats(); | ||
| expect(stats.totalRequests).toContain('100'); | ||
| expect(stats.avgDuration).toContain('45.5'); | ||
| expect(stats.cacheHitRate).toContain('85.0%'); | ||
| expect(stats.successRate).toContain('98.0%'); | ||
| }); | ||
|
|
||
| it('should navigate when navigateTo is called', async () => { | ||
| const router = TestBed.inject(Router); | ||
| const navigateSpy = vi.spyOn(router, 'navigate').mockResolvedValue(true); | ||
| component.navigateTo('/compiler'); | ||
| expect(navigateSpy).toHaveBeenCalledWith(['/compiler']); | ||
| }); | ||
|
|
||
| it('should open absolute external URLs in a new tab via window.open', () => { | ||
| const openSpy = vi.spyOn(window, 'open').mockImplementation(() => null); | ||
| component.navigateTo('https://docs.example.com/', true); | ||
| expect(openSpy).toHaveBeenCalledWith('https://docs.example.com/', '_blank', 'noopener,noreferrer'); | ||
| }); | ||
|
|
||
| it('should open worker-handled relative paths in a new tab when external flag is true', () => { | ||
| const openSpy = vi.spyOn(window, 'open').mockImplementation(() => null); | ||
| component.navigateTo('/admin', true); | ||
| expect(openSpy).toHaveBeenCalledWith('/admin', '_blank', 'noopener,noreferrer'); | ||
| }); | ||
|
|
||
| it('should NOT call window.open for internal paths without external flag', async () => { | ||
| const router = TestBed.inject(Router); | ||
| const navigateSpy = vi.spyOn(router, 'navigate').mockResolvedValue(true); | ||
| const openSpy = vi.spyOn(window, 'open').mockImplementation(() => null); | ||
| component.navigateTo('/performance'); | ||
| expect(openSpy).not.toHaveBeenCalled(); | ||
| expect(navigateSpy).toHaveBeenCalledWith(['/performance']); | ||
| }); | ||
|
|
||
| it('should navigate to performance on stat card click for Total Requests', async () => { | ||
| const router = TestBed.inject(Router); | ||
| const navigateSpy = vi.spyOn(router, 'navigate').mockResolvedValue(true); | ||
| component.onStatCardClicked('Total Requests'); | ||
| expect(navigateSpy).toHaveBeenCalledWith(['/performance']); | ||
| }); | ||
|
|
||
| it('should navigate to performance on stat card click for Avg Response Time', async () => { | ||
| const router = TestBed.inject(Router); | ||
| const navigateSpy = vi.spyOn(router, 'navigate').mockResolvedValue(true); | ||
| component.onStatCardClicked('Avg Response Time'); | ||
| expect(navigateSpy).toHaveBeenCalledWith(['/performance']); | ||
| }); | ||
|
|
||
| it('should render footer section', async () => { | ||
| it('should not navigate for non-metric stat card clicks', async () => { | ||
| const router = TestBed.inject(Router); | ||
| const navigateSpy = vi.spyOn(router, 'navigate').mockResolvedValue(true); | ||
| component.onStatCardClicked('Cache Hit Rate'); | ||
| expect(navigateSpy).not.toHaveBeenCalled(); | ||
| }); | ||
|
|
||
| it('should show default health icon when no data', async () => { | ||
| // After the flush in beforeEach, health is 'healthy' | ||
| expect(component.healthIcon()).toBe('check_circle'); | ||
| }); | ||
|
|
||
| it('should show default health color when no data', async () => { | ||
| // After the flush in beforeEach, health is 'healthy' | ||
| expect(component.healthColor()).toBe('var(--app-success, #4caf50)'); | ||
| }); | ||
|
|
||
| it('should render the page heading', async () => { | ||
| await fixture.whenStable(); | ||
| const footer = fixture.nativeElement.querySelector('app-footer-section'); | ||
| expect(footer).toBeTruthy(); | ||
| fixture.detectChanges(); | ||
| const h1 = fixture.nativeElement.querySelector('h1'); | ||
| expect(h1?.textContent).toContain('Adblock Compiler Dashboard'); | ||
| }); | ||
| }); | ||
|
|
||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.