fix: restore full-featured dashboard, remove landing page sections introduced by #1582#1583
Merged
jaypatrick merged 3 commits intomainfrom Apr 14, 2026
Merged
Conversation
Agent-Logs-Url: https://github.com/jaypatrick/adblock-compiler/sessions/217b35cf-08ad-41bd-8fd4-5914d80c0aa4 Co-authored-by: jaypatrick <[email protected]>
Copilot
AI
changed the title
[WIP] Restore full-featured Adblock Compiler dashboard
fix: restore full-featured dashboard, remove landing page sections introduced by #1582
Apr 14, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Reverts PR #1582’s landing-page takeover of / and restores the original application dashboard while keeping the Bloqr design-system styling updates.
Changes:
- Restores the full dashboard
HomeComponent(system health, live stats, queue chart, quick actions, nav cards, endpoints table, settings, deferred API tester). - Reverts
AppComponentto always render the app shell header/footer on/(removes landing-page route gating). - Removes the 10 marketing landing-page section components and updates the bundled logo asset.
Reviewed changes
Copilot reviewed 14 out of 15 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| frontend/src/app/home/home.component.ts | Restores the dashboard UI/composition and related state/computed values. |
| frontend/src/app/home/home.component.spec.ts | Restores/expands dashboard unit tests and HTTP mocking for MetricsStore. |
| frontend/src/app/app.component.ts | Removes landing-page shell gating so header/footer render on all routes. |
| frontend/src/app/app.component.spec.ts | Reverts tests to no longer depend on a stub route/component for shell visibility. |
| frontend/src/assets/logo.svg | Replaces the prior mark with the canonical bar/wordmark SVG asset. |
| frontend/src/app/home/sections/audiences-section/audiences-section.component.ts | Deleted (landing-page section removed). |
| frontend/src/app/home/sections/byo-section/byo-section.component.ts | Deleted (landing-page section removed). |
| frontend/src/app/home/sections/cta-banner-section/cta-banner-section.component.ts | Deleted (landing-page section removed). |
| frontend/src/app/home/sections/features-section/features-section.component.ts | Deleted (landing-page section removed). |
| frontend/src/app/home/sections/footer-section/footer-section.component.ts | Deleted (landing-page section removed). |
| frontend/src/app/home/sections/hero-section/hero-section.component.ts | Deleted (landing-page section removed). |
| frontend/src/app/home/sections/how-it-works-section/how-it-works-section.component.ts | Deleted (landing-page section removed). |
| frontend/src/app/home/sections/nav-bar/nav-bar.component.ts | Deleted (landing-page section removed). |
| frontend/src/app/home/sections/pricing-section/pricing-section.component.ts | Deleted (landing-page section removed). |
| frontend/src/app/home/sections/problem-section/problem-section.component.ts | Deleted (landing-page section removed). |
Owner
|
@copilot apply changes based on the comments in this thread |
Agent-Logs-Url: https://github.com/jaypatrick/adblock-compiler/sessions/8527e971-8b1f-4ba3-8f1b-4d5884c0162e Co-authored-by: jaypatrick <[email protected]>
Contributor
Author
Applied all reviewer feedback in commit
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #1582 replaced the application dashboard at
/with a 10-section marketing landing page and conditionally hid the app shell header/footer on that route. The marketing landing page belongs injaypatrick/bloqr-landing, not here. This PR reverts those structural changes while keeping all Bloqr design system additions (#1581/#1582 styles, fonts, tokens).Changes
Restored
home.component.ts— full dashboard: system health bar, 5-stat live grid, queue depth chart, quick actions, 6 nav cards, 9-endpoint comparison table, notification/auto-refresh settings, deferredApiTesterComponent. All original signals, computed values, and service injections retained (MetricsStore,NotificationService,LogService,LiveAnnouncer,DestroyRef). Bloqr dark design language applied (Space Grotesk headings, Inter body,#FF5500orange accent,#0E1829card surface).cacheHitRateandsuccessRateformatted correctly as already-percentage values (0–100) perMetricsServicecontract, consistent withPerformanceComponent.home.component.spec.ts— 15 tests covering nav cards, stat card navigation, health icon/color,navigateTo()external/internal routing,onStatCardClicked(), and page heading. Health status type aligned toHealthResponse('unhealthy'not'down'); metric fixtures use percentage-style values (cacheHitRate: 85, successRate: 98) matchingmetrics.service.spec.tsandmetrics.store.spec.ts;afterEachno longer masks unexpected requests with a catch-all flush.Reverted
app.component.ts— removedisLandingPagesignal,Router/NavigationEnd/filterimports added by feat: Implement Bloqr landing page — 10 section components, dark design system, SSR-safe persona tabs, a11y hardening #1582;<header>and<footer>shell elements now render unconditionally on all routesapp.component.spec.ts— removedStubComponentand its stale doc comment; mobile test restored toprovideRouter([])with description'should render menu button with aria-label'Deleted
frontend/src/app/home/sections/— all 10 landing page components:audiences-section,byo-section,cta-banner-section,features-section,footer-section,hero-section,how-it-works-section,nav-bar,pricing-section,problem-sectionUpdated
frontend/src/assets/logo.svg— replaced shield-B mark with canonical bar-wordmark frombloqr-landing/brand/logo.svg(filter-list icon + ADBLOCK/COMPILER wordmark)Preserved from #1581/#1582 (not reverted)
styles.cssBloqr design tokens (dark M3 palette, Space Grotesk/Inter font stack,.bloqr-card,.bloqr-btn-primaryutilities)@fontsource/space-groteskand@fontsource/interfont packagesjosesecurity override inpackage.json/pnpm-lock.yamldocs.routes.tsreferrerpolicy hardeningindex.htmlBloqr meta/titleTesting
home.component.spec.ts; 1052/1052 tests passZero Trust Architecture Checklist
Worker / Backend
*) on write/authenticated endpoints — N/A[vars]) — N/A.prepare().bind()(no string interpolation) — N/AFrontend / Angular
CanActivateFnauth guards — no new routes added; existing guards unchangedlocalStorage) — N/A (no auth changes)MetricsStore, no new API calls)API Shield / Vulnerability Scanner
operationIdinopenapi.yaml— N/A (no endpoint changes)security:annotation — N/A404— N/Acloudflare-schema.yamlregenerated ifopenapi.yamlchanged — N/AOriginal prompt
Summary
PR #1582 incorrectly replaced the full-featured Adblock Compiler dashboard at route
/with a marketing landing page. A standalone landing page already exists atjaypatrick/bloqr-landing. The app atjaypatrick/adblock-compilershould be the application — the dashboard, tools, and functionality — styled with the Bloqr design language. The landing page inside the app must be removed entirely.This PR must:
home.component.ts— the full-featured dashboard (NOT the landing page sections)home.component.spec.ts— the full 14-test suite (NOT the 4 stub tests)frontend/src/app/home/sections/app.component.ts— removeisLandingPagesignal, remove the@if (!isLandingPage())gating on header and footer, removeRouter/NavigationEndimports added by feat: Implement Bloqr landing page — 10 section components, dark design system, SSR-safe persona tabs, a11y hardening #1582app.component.spec.ts— removeStubComponent, remove the/compilernavigation in the mobile test; restore the original simpleshould render menu button with aria-labeltestfrontend/src/assets/logo.svg— replace the shield-B mark committed by feat: Implement Bloqr landing page — 10 section components, dark design system, SSR-safe persona tabs, a11y hardening #1582 with the canonical bar-wordmark logo fromjaypatrick/bloqr-landing/brand/logo.svgWhat to KEEP (do NOT revert these)
frontend/src/styles.cssBloqr design tokens and utility classes introduced by feat: redesign frontend and API with Bloqr brand design system #1581 and feat: Implement Bloqr landing page — 10 section components, dark design system, SSR-safe persona tabs, a11y hardening #1582 (Space Grotesk/Inter fonts, dark M3 tokens,.bloqr-card,.bloqr-btn-primary,.bloqr-section-label, etc.)josesecurity override inpackage.jsonandpnpm-lock.yamlworker/routes/docs.routes.tsreferrerpolicyhardeningfrontend/src/index.htmlBloqr meta/title updates from feat: redesign frontend and API with Bloqr brand design system #1581frontend/package.jsonandpnpm-lock.yaml(@fontsource/space-grotesk, @fontsource/inter replacing ibm-plex-sans/syne)Detailed Specifications
1.
frontend/src/assets/logo.svg— Replace with canonical bar-wordmarkReplace the current shield-B logo with this exact SVG (the canonical Bloqr bar-wordmark from
jaypatrick/bloqr-landing/brand/logo.svg):2.
frontend/src/app/home/home.component.ts— Restore full dashboardReplace the current landing-page composition with the full-featured dashboard. Apply the Bloqr design language (dark theme tokens, Space Grotesk typography, orange accents,
.bloqr-cardclasses) while preserving ALL original dashboard functionality:QueueChartComponent)ApiTesterComponent)The dashboard header should use:
Cards should use
.bloqr-cardclass where appropriate, and the Material card components must keep their current imports/structure. The component must retain all signals, computed values, injected services, and methods from the pre-#1582 version:navCards: NavCard[](6 entries)endpointComparison: EndpointInfo[](9 entries)highlightedCard,showTester,testerCollapsedsignalsautoRefreshEnabled,autoRefreshIntervalstatestore = inject(MetricsStore)notifications = inject(NotificationService)log = inject(LogService)liveAnnouncer = inject(LiveAnnouncer)router = inject(Router)This pull request was created from Copilot chat.