Skip to content

add TCK tests for eager initialization (@Eager)#659

Merged
Ladicek merged 2 commits intojakartaee:mainfrom
Ladicek:eager-init
Apr 21, 2026
Merged

add TCK tests for eager initialization (@Eager)#659
Ladicek merged 2 commits intojakartaee:mainfrom
Ladicek:eager-init

Conversation

@Ladicek
Copy link
Copy Markdown
Member

@Ladicek Ladicek commented Nov 7, 2025

TCK tests for jakartaee/cdi#911

@Ladicek
Copy link
Copy Markdown
Member Author

Ladicek commented Nov 7, 2025

This is a draft, because:

Other than that, this should be complete I believe.

@Ladicek
Copy link
Copy Markdown
Member Author

Ladicek commented Nov 10, 2025

Added tests for @Eager on a stereotype.

Also added a 2nd commit with missing tests for Bean.isReserve() -- I forgot to include those in a previous PR. I'm too lazy to open an extra PR for this :-)

@Ladicek Ladicek force-pushed the eager-init branch 2 times, most recently from ee7eab1 to e332ab4 Compare November 10, 2025 14:22
@Ladicek
Copy link
Copy Markdown
Member Author

Ladicek commented Mar 26, 2026

Rebased and updated to reflect the latest spec text. Ready for review, although there is still a dependency on SNAPSHOT, so not ready for merging yet.

@Ladicek Ladicek marked this pull request as ready for review March 26, 2026 15:28
@Ladicek Ladicek requested review from Azquelt and manovotn March 26, 2026 15:29
@manovotn manovotn added this to the CDI 5.0 milestone Apr 15, 2026
@Ladicek
Copy link
Copy Markdown
Member Author

Ladicek commented Apr 16, 2026

Rebased. No SNAPSHOT dependency anymore.

Copy link
Copy Markdown
Contributor

@manovotn manovotn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few small notes. Otherwise looks good

@Ladicek
Copy link
Copy Markdown
Member Author

Ladicek commented Apr 21, 2026

@manovotn See the last comments from @Azquelt -- I hope the one change of scope is OK for you, but I vaguely recall discovery works differently in Weld, so would be good to have another look.

@manovotn
Copy link
Copy Markdown
Contributor

@manovotn See the last comments from @Azquelt -- I hope the one change of scope is OK for you, but I vaguely recall discovery works differently in Weld, so would be good to have another look.

Yea, that breaks my current implementation. Let me take a closer look at what's going on there...

@manovotn
Copy link
Copy Markdown
Contributor

@manovotn See the last comments from @Azquelt -- I hope the one change of scope is OK for you, but I vaguely recall discovery works differently in Weld, so would be good to have another look.

Yea, that breaks my current implementation. Let me take a closer look at what's going on there...

@Ladicek the discovery is not the issue here, it's the validation.
IIRC, Weld does validation per-bean, not on the stereotype itself. And the bean it perfectly valid.

I think we had a similar discussion regarding alternative and reserve on a stereotype and I can see I added

@manovotn
Copy link
Copy Markdown
Contributor

@manovotn See the last comments from @Azquelt -- I hope the one change of scope is OK for you, but I vaguely recall discovery works differently in Weld, so would be good to have another look.

Yea, that breaks my current implementation. Let me take a closer look at what's going on there...

@Ladicek the discovery is not the issue here, it's the validation. IIRC, Weld does validation per-bean, not on the stereotype itself. And the bean it perfectly valid.

I think we had a similar discussion regarding alternative and reserve on a stereotype and I can see I added

OK, fixed now, thanks for pointing it out 👍

@Ladicek Ladicek merged commit 5992350 into jakartaee:main Apr 21, 2026
4 checks passed
@Ladicek Ladicek deleted the eager-init branch April 21, 2026 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants