Skip to content

add TCK tests for auto-closeable beans (@AutoClose)#709

Open
Ladicek wants to merge 5 commits intojakartaee:mainfrom
Ladicek:auto-close
Open

add TCK tests for auto-closeable beans (@AutoClose)#709
Ladicek wants to merge 5 commits intojakartaee:mainfrom
Ladicek:auto-close

Conversation

@Ladicek
Copy link
Copy Markdown
Member

@Ladicek Ladicek commented Apr 17, 2026

Fixes #700

@Ladicek Ladicek requested review from Azquelt and manovotn April 17, 2026 14:58
@Ladicek
Copy link
Copy Markdown
Member Author

Ladicek commented Apr 17, 2026

This is no longer a draft for 2 reasons because:

Other than that, it should be fine. Submitting it now for @manovotn's ongoing work.

@Ladicek
Copy link
Copy Markdown
Member Author

Ladicek commented Apr 20, 2026

Added tests for Producer, but note I didn't run them, because they only make sense for CDI Full.

@Ladicek Ladicek marked this pull request as ready for review April 22, 2026 10:14
@Ladicek
Copy link
Copy Markdown
Member Author

Ladicek commented Apr 22, 2026

Added a test that the call to AutoCloseable.close() during bean destruction is not a business method invocation. This is ready now.

The commits in this PR could be squashed, but don't necessarily have to be; I don't mind.

@Ladicek Ladicek added this to the CDI 5.0 milestone Apr 27, 2026
@Ladicek
Copy link
Copy Markdown
Member Author

Ladicek commented May 4, 2026

Rebased, this can be merged now as there's no SNAPSHOT dependency anymore. Of course, after it's reviewed :-)

@Ladicek
Copy link
Copy Markdown
Member Author

Ladicek commented May 6, 2026

Added one more commit that tests that auto-closeable dependent objects are closed when the containing bean is destroyed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Create TCK coverage for the @AutoClose feature

2 participants