-
Notifications
You must be signed in to change notification settings - Fork 3.5k
experiment with texture streaming off #5686
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
huidongc
wants to merge
8
commits into
isaac-sim:develop
Choose a base branch
from
huidongc:deterministic-rtx-rendering
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
f0cfb53
experiment with texture streaming off
huidongc 1adfc8a
golden images
huidongc 441245d
changelog fragment
huidongc eb89a15
golden images
huidongc babfbd1
OVRTX still under investigation
huidongc 8a8f2b8
show ovrtx logs in stdout, reduce log verbosity to info level
huidongc 12fbfb7
changelog
huidongc e137c79
restore to verbose
huidongc File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 changes: 4 additions & 0 deletions
4
source/isaaclab_ov/changelog.d/huidongc-deterministic-rtx-rendering.rst
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| Changed | ||
| ^^^^^^^ | ||
|
|
||
| * Changed :attr:`~isaaclab_ov.renderers.OVRTXRendererCfg.log_file_path` default to ``"/dev/stdout"``. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Empty file.
4 changes: 2 additions & 2 deletions
4
...isaaclab_tasks/test/golden_images/cartpole/newton-isaacsim_rtx_renderer-rgb.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
4 changes: 2 additions & 2 deletions
4
...saaclab_tasks/test/golden_images/cartpole/newton-isaacsim_rtx_renderer-rgba.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
4 changes: 2 additions & 2 deletions
4
.../isaaclab_tasks/test/golden_images/cartpole/physx-isaacsim_rtx_renderer-rgb.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
4 changes: 2 additions & 2 deletions
4
...isaaclab_tasks/test/golden_images/cartpole/physx-isaacsim_rtx_renderer-rgba.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
4 changes: 2 additions & 2 deletions
4
..._tasks/test/golden_images/dexsuite_kuka/newton-isaacsim_rtx_renderer-albedo.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
4 changes: 2 additions & 2 deletions
4
...lab_tasks/test/golden_images/dexsuite_kuka/newton-isaacsim_rtx_renderer-rgb.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
4 changes: 2 additions & 2 deletions
4
...ab_tasks/test/golden_images/dexsuite_kuka/newton-isaacsim_rtx_renderer-rgba.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
4 changes: 2 additions & 2 deletions
4
...mages/dexsuite_kuka/newton-isaacsim_rtx_renderer-simple_shading_diffuse_mdl.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
4 changes: 2 additions & 2 deletions
4
...n_images/dexsuite_kuka/newton-isaacsim_rtx_renderer-simple_shading_full_mdl.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
4 changes: 2 additions & 2 deletions
4
...b_tasks/test/golden_images/dexsuite_kuka/physx-isaacsim_rtx_renderer-albedo.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
4 changes: 2 additions & 2 deletions
4
...clab_tasks/test/golden_images/dexsuite_kuka/physx-isaacsim_rtx_renderer-rgb.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
4 changes: 2 additions & 2 deletions
4
...lab_tasks/test/golden_images/dexsuite_kuka/physx-isaacsim_rtx_renderer-rgba.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
4 changes: 2 additions & 2 deletions
4
...images/dexsuite_kuka/physx-isaacsim_rtx_renderer-simple_shading_diffuse_mdl.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
4 changes: 2 additions & 2 deletions
4
...en_images/dexsuite_kuka/physx-isaacsim_rtx_renderer-simple_shading_full_mdl.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
4 changes: 2 additions & 2 deletions
4
...saac-Cartpole-Camera-Presets-Direct-v0/default_physics-default_renderer-rgb.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
4 changes: 2 additions & 2 deletions
4
...aac-Cartpole-Camera-Presets-Direct-v0/default_physics-default_renderer-rgba.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
4 changes: 2 additions & 2 deletions
4
...ks/Isaac-Cartpole-RGB-Camera-Direct-v0/default_physics-default_renderer-rgb.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
4 changes: 2 additions & 2 deletions
4
...s/Isaac-Cartpole-RGB-Camera-Direct-v0/default_physics-default_renderer-rgba.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
4 changes: 2 additions & 2 deletions
4
...ac-Repose-Cube-Shadow-Vision-Direct-v0/default_physics-default_renderer-rgb.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
4 changes: 2 additions & 2 deletions
4
...c-Repose-Cube-Shadow-Vision-Direct-v0/default_physics-default_renderer-rgba.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
4 changes: 2 additions & 2 deletions
4
...ab_tasks/test/golden_images/shadow_hand/newton-isaacsim_rtx_renderer-albedo.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
4 changes: 2 additions & 2 deletions
4
...aclab_tasks/test/golden_images/shadow_hand/newton-isaacsim_rtx_renderer-rgb.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
4 changes: 2 additions & 2 deletions
4
...clab_tasks/test/golden_images/shadow_hand/newton-isaacsim_rtx_renderer-rgba.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
4 changes: 2 additions & 2 deletions
4
..._images/shadow_hand/newton-isaacsim_rtx_renderer-simple_shading_diffuse_mdl.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
4 changes: 2 additions & 2 deletions
4
...lab_tasks/test/golden_images/shadow_hand/physx-isaacsim_rtx_renderer-albedo.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
4 changes: 2 additions & 2 deletions
4
...aaclab_tasks/test/golden_images/shadow_hand/physx-isaacsim_rtx_renderer-rgb.png
Oops, something went wrong.
4 changes: 2 additions & 2 deletions
4
...aclab_tasks/test/golden_images/shadow_hand/physx-isaacsim_rtx_renderer-rgba.png
Oops, something went wrong.
4 changes: 2 additions & 2 deletions
4
...n_images/shadow_hand/physx-isaacsim_rtx_renderer-simple_shading_diffuse_mdl.png
Oops, something went wrong.
4 changes: 2 additions & 2 deletions
4
...lden_images/shadow_hand/physx-isaacsim_rtx_renderer-simple_shading_full_mdl.png
Oops, something went wrong.
4 changes: 2 additions & 2 deletions
4
source/isaaclab_tasks/test/golden_images/shadow_hand/physx-newton_renderer-rgb.png
Oops, something went wrong.
4 changes: 2 additions & 2 deletions
4
...ce/isaaclab_tasks/test/golden_images/shadow_hand/physx-newton_renderer-rgba.png
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
isaaclab.python.headless.kitis the shared app configuration loaded for every headless Isaac Lab run (training scripts, data-collection pipelines, etc.), not solely by CI rendering tests. Disabling texture streaming may change startup time, VRAM usage, and rendering fidelity for all downstream users. There is no comment here (or in the PR description) explaining whether this is intended to be permanent or is scoped to the test experiment.