Skip to content
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions test/unit_test/memory/utils/test_ob_conn_aggregation.py
Original file line number Diff line number Diff line change
Expand Up @@ -53,3 +53,22 @@ def test_pre_aggregated_value_count_rows(self):
]
out = aggregate_by_field(messages, "message_type_kwd")
assert set(out) == {("user", 2), ("assistant", 1)}

def test_aggregates_list_values_and_trims_whitespace(self):
messages = [
{"id": "m1", "tags_kwd": [" alpha ", "beta", ""]},
{"id": "m2", "tags_kwd": ["alpha", " beta "]},
{"id": "m3", "tags_kwd": ["gamma", None, 1]},
]
out = aggregate_by_field(messages, "tags_kwd")
assert set(out) == {("alpha", 2), ("beta", 2), ("gamma", 1)}

def test_ignores_non_string_and_blank_scalar_values(self):
messages = [
{"id": "m1", "message_type_kwd": " "},
{"id": "m2", "message_type_kwd": None},
{"id": "m3", "message_type_kwd": 1},
{"id": "m4", "message_type_kwd": "assistant"},
]
out = aggregate_by_field(messages, "message_type_kwd")
assert out == [("assistant", 1)]
Comment thread
coderabbitai[bot] marked this conversation as resolved.