Test : aggregation edge cases for list and scalar values#14170
Test : aggregation edge cases for list and scalar values#14170Achieve3318 wants to merge 2 commits intoinfiniflow:mainfrom
Conversation
|
Warning Rate limit exceeded
Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 8 minutes and 44 seconds. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughAdded two new unit tests for the Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~5 minutes Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Comment |
Add focused unit tests to verify whitespace trimming and non-string filtering behavior in memory aggregation results.
7fa1917 to
b7b8021
Compare
|
Hi, @yingfeng , Could you review my PR, please? |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@test/unit_test/memory/utils/test_ob_conn_aggregation.py`:
- Around line 57-74: The two new tests
test_aggregates_list_values_and_trims_whitespace and
test_ignores_non_string_and_blank_scalar_values are missing the required pytest
priority markers; add the appropriate pytest marker (e.g., `@pytest.mark.p1` or
`@pytest.mark.p2/`@pytest.mark.p3 per project guidelines) above each test function
so they include a priority marker, and ensure you import pytest if not already
present so the decorators resolve.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 16f5e3ca-fd10-4cdf-b683-109f1fb55000
📒 Files selected for processing (1)
test/unit_test/memory/utils/test_ob_conn_aggregation.py
Ensure new unit tests follow test suite marker conventions for CI and reviewer checks.
|
Hi, @yingfeng , Could you review my PR, please? |
|
hi, @yingfeng , Could you review my PR? |
|
Hi, @yingfeng , Could you review my PR, please? |
This PR adds focused unit tests for aggregate_by_field in OceanBase memory utilities to improve behavior coverage for real-world input shapes.
Why this helps
It strengthens regression protection for aggregation logic used by memory retrieval flows, with no production code changes and minimal review risk.