Refactor Source Generator

.editorconfig

@@ -3,4 +3,14 @@ root = true
 [*.cs]
 
 dotnet_diagnostic.IDE0056.severity = none
-dotnet_diagnostic.IDE0057.severity = none
+dotnet_diagnostic.IDE0057.severity = none
+
+# Verify settings
+[*.{received,verified}.{json,txt,xml,cs}]
+charset = utf-8-bom
+end_of_line = lf
+indent_size = unset
+indent_style = unset
+insert_final_newline = false
+tab_width = unset
+trim_trailing_whitespace = false

.gitattributes

@@ -3,6 +3,16 @@
 ###############################################################################
 * text=auto
 
+###############################################################################
+# Verify settings
+###############################################################################
+
+*.verified.txt text eol=lf working-tree-encoding=UTF-8
+*.verified.xml text eol=lf working-tree-encoding=UTF-8
+*.verified.json text eol=lf working-tree-encoding=UTF-8
+*.verified.cs text eol=lf working-tree-encoding=UTF-8
+*.verified.bin binary
+
 ###############################################################################
 # Set default behavior for command prompt diff.
 #

.gitignore

@@ -215,9 +215,15 @@ TfsCmdlets.PSDesktop.xml
 
 CSharp/.idea/**
 
+# Verify files
+
+*.received.*
+*.received/
+
 # Miscellaneous files
 
 CSharp/*/Generated/**
 Docs/AzDO-Security-Actions.csv
 **/testResults.xml
 PS/_Tests/coverage.xml
+CSharp/**/Old/**

.vscode/settings.json

@@ -41,5 +41,6 @@
         "titleBar.inactiveForeground": "#e7e7e799"
     },
     "peacock.color": "Indigo",
-    "dotnet.preferCSharpExtension": false
+    "dotnet.preferCSharpExtension": false,
+    "dotnet.defaultSolution": "CSharp/TfsCmdlets.sln"
 }

CSharp/TfsCmdlets.Legacy/TfsCmdlets.Legacy.csproj

@@ -24,7 +24,7 @@
     <PackageReference Include="Microsoft.VisualStudio.Services.Search.Client" Version="16.*-*" />
     <PackageReference Include="Microsoft.VisualStudio.Services.ServiceEndpoints.WebApi" Version="16.*-*" />
     <PackageReference Include="Microsoft.VisualStudio.Services.ServiceHooks.WebApi" Version="16.*-*" />
-    <PackageReference Include="PowerShellStandard.Library" Version="7.0.0-preview.1" PrivateAssets="all" />
+    <PackageReference Include="PowerShellStandard.Library" Version="5.*" PrivateAssets="all" />
     <PackageReference Include="System.IO.Compression.ZipFile" Version="4.3.0" />
     <PackageReference Include="System.Composition" Version="5.0.1" />
     <PackageReference Include="System.Composition.Hosting" Version="5.0.1" />

CSharp/TfsCmdlets.Shared/CmdletControllerAttribute.cs

@@ -0,0 +1,28 @@
+namespace TfsCmdlets {
+
+    [AttributeUsage(System.AttributeTargets.Class, Inherited = true, AllowMultiple = false)]
+    public sealed class CmdletControllerAttribute : ExportAttribute
+    {
+        public Type DataType { get; }
+
+        public string CustomCmdletName { get; set; }
+
+        public string[] CustomVerbs { get; set; }
+
+        public string[] CustomNouns { get; set; }
+
+        public Type CustomBaseClass { get; set; }
+
+        public Type Client { get; set; }
+
+
+        public CmdletControllerAttribute() : base(typeof(IController))
+        {
+        }
+
+        public CmdletControllerAttribute(Type dataType) : base(typeof(IController))
+        {
+            DataType = dataType;
+        }
+    }
+}

CSharp/TfsCmdlets/Cmdlets/WorkItem/AreasIterations/CopyClassificationNodeController.cs → CSharp/TfsCmdlets.Shared/Cmdlets/WorkItem/AreasIterations/CopyClassificationNodeController.cs

@@ -4,7 +4,7 @@
 
 namespace TfsCmdlets.Cmdlets.WorkItem.AreasIterations
 {
-    internal abstract class CopyClassificationNodeController: ControllerBase
+    public abstract class CopyClassificationNodeController: ControllerBase
     {
         protected override IEnumerable Run()
         {

CSharp/TfsCmdlets/Cmdlets/WorkItem/AreasIterations/GetClassificationNodeController.cs → CSharp/TfsCmdlets.Shared/Cmdlets/WorkItem/AreasIterations/GetClassificationNodeController.cs

@@ -4,7 +4,7 @@
 
 namespace TfsCmdlets.Cmdlets.WorkItem.AreasIterations
 {
-    internal abstract class GetClassificationNodeController: ControllerBase
+    public abstract class GetClassificationNodeController: ControllerBase
     {
         private INodeUtil NodeUtil { get; set;  }
 
@@ -81,7 +81,7 @@ protected override IEnumerable Run()
         }
 
         [ImportingConstructor]
-        protected GetClassificationNodeController(INodeUtil nodeUtil, IPowerShellService powerShell, IDataManager data, IParameterManager parameters, ILogger logger, IWorkItemTrackingHttpClient client)
+        protected GetClassificationNodeController(INodeUtil nodeUtil, IWorkItemTrackingHttpClient client, IPowerShellService powerShell, IDataManager data, IParameterManager parameters, ILogger logger)
             : base(powerShell, data, parameters, logger)
         {
             NodeUtil = nodeUtil;

CSharp/TfsCmdlets/Cmdlets/WorkItem/AreasIterations/MoveClassificationNodeController.cs → CSharp/TfsCmdlets.Shared/Cmdlets/WorkItem/AreasIterations/MoveClassificationNodeController.cs

@@ -5,7 +5,7 @@
 
 namespace TfsCmdlets.Cmdlets.WorkItem.AreasIterations
 {
-    internal abstract class MoveClassificationNodeController : ControllerBase
+    public abstract class MoveClassificationNodeController : ControllerBase
     {
         private IWorkItemTrackingHttpClient Client { get; set; }
 

CSharp/TfsCmdlets/Cmdlets/WorkItem/AreasIterations/NewClassificationNodeController.cs → CSharp/TfsCmdlets.Shared/Cmdlets/WorkItem/AreasIterations/NewClassificationNodeController.cs

@@ -4,7 +4,7 @@
 
 namespace TfsCmdlets.Cmdlets.WorkItem.AreasIterations
 {
-    internal abstract class NewClassificationNodeController: ControllerBase
+    public abstract class NewClassificationNodeController: ControllerBase
     {
         private INodeUtil NodeUtil { get; }
 

CSharp/TfsCmdlets/Cmdlets/WorkItem/AreasIterations/RemoveClassificationNodeController.cs → CSharp/TfsCmdlets.Shared/Cmdlets/WorkItem/AreasIterations/RemoveClassificationNodeController.cs

@@ -4,7 +4,7 @@
 
 namespace TfsCmdlets.Cmdlets.WorkItem.AreasIterations
 {
-    internal abstract class RemoveClassificationNodeController: ControllerBase
+    public abstract class RemoveClassificationNodeController: ControllerBase
     {
         private IWorkItemTrackingHttpClient Client { get; set; }
 

CSharp/TfsCmdlets/Cmdlets/WorkItem/AreasIterations/TestClassificationNodeController.cs → CSharp/TfsCmdlets.Shared/Cmdlets/WorkItem/AreasIterations/TestClassificationNodeController.cs

@@ -1,6 +1,6 @@
 namespace TfsCmdlets.Cmdlets.WorkItem.AreasIterations
 {
-    internal abstract class TestClassificationNodeController: ControllerBase
+    public abstract class TestClassificationNodeController: ControllerBase
     {
         protected override IEnumerable Run()
         {

CSharp/TfsCmdlets/Cmdlets/WorkItem/Tagging/ToggleWorkItemTagController.cs → CSharp/TfsCmdlets.Shared/Cmdlets/WorkItem/Tagging/ToggleWorkItemTagController.cs

@@ -2,7 +2,7 @@
 
 namespace TfsCmdlets.Cmdlets.WorkItem.Tagging
 {
-    internal abstract class ToggleWorkItemTagController: ControllerBase
+    public abstract class ToggleWorkItemTagController: ControllerBase
     {
         [Import]
         private ITaggingHttpClient Client { get; set; }
@@ -16,9 +16,12 @@
             foreach (var tag in tags)
             {
                 if (!PowerShell.ShouldProcess(tp, $"{(enabled? "Enable": "Disable")} work item tag '{tag.Name}'")) continue;
-
-                yield return Client.UpdateTagAsync(tp.Id, tag.Id, tag.Name, enabled)
-                    .GetResult($"Error renaming work item tag '{tag.Name}'");
+#if UNIT_TEST_PROJECT
+                    yield break;
+#else
+                    yield return Client.UpdateTagAsync(tp.Id, tag.Id, tag.Name, enabled)
+                        .GetResult($"Error renaming work item tag '{tag.Name}'");
+#endif
             }
         }
 

CSharp/TfsCmdlets/HttpClients/HttpClientAttribute.cs → CSharp/TfsCmdlets.Shared/HttpClientAttribute.cs

@@ -1,6 +1,6 @@
-namespace TfsCmdlets.HttpClients
+namespace TfsCmdlets
 {
-    internal class HttpClientAttribute : Attribute
+    public sealed class HttpClientAttribute : Attribute
     {
         public HttpClientAttribute(Type type)
         {

CSharp/TfsCmdlets/HttpClients/IAccountLicensingHttpClient.cs → CSharp/TfsCmdlets.Shared/HttpClients/IAccountLicensingHttpClient.cs

@@ -3,7 +3,7 @@
 namespace TfsCmdlets.HttpClients
 {
     [HttpClient(typeof(AccountLicensingHttpClient))]
-    partial interface IAccountLicensingHttpClient
+    public partial interface IAccountLicensingHttpClient
     {
     }
 }

CSharp/TfsCmdlets/HttpClients/IBuildHttpClient.cs → CSharp/TfsCmdlets.Shared/HttpClients/IBuildHttpClient.cs

@@ -3,7 +3,7 @@
 namespace TfsCmdlets.HttpClients
 {
     [HttpClient(typeof(BuildHttpClient))]
-    partial interface IBuildHttpClient
+    public partial interface IBuildHttpClient
     {
     }
 }

CSharp/TfsCmdlets/HttpClients/IExtensionManagementHttpClient.cs → CSharp/TfsCmdlets.Shared/HttpClients/IExtensionManagementHttpClient.cs

@@ -3,7 +3,7 @@
 namespace TfsCmdlets.HttpClients
 {
     [HttpClient(typeof(ExtensionManagementHttpClient))]
-    partial interface IExtensionManagementHttpClient
+    public partial interface IExtensionManagementHttpClient
     {
     }
 }

CSharp/TfsCmdlets/HttpClients/IFeedHttpClient.cs → CSharp/TfsCmdlets.Shared/HttpClients/IFeedHttpClient.cs

@@ -3,7 +3,7 @@
 namespace TfsCmdlets.HttpClients {
 
     [HttpClient(typeof(FeedHttpClient))]
-    partial interface IFeedHttpClient {
+    public partial interface IFeedHttpClient {
 
     }
 }

CSharp/TfsCmdlets/HttpClients/IGenericHttpClient.cs → CSharp/TfsCmdlets.Shared/HttpClients/IGenericHttpClient.cs

@@ -1,7 +1,7 @@
 namespace TfsCmdlets.HttpClients
 {
     [HttpClient(typeof(GenericHttpClient))]
-    partial interface IGenericHttpClient
+    public partial interface IGenericHttpClient
     {
     }
 }

CSharp/TfsCmdlets/HttpClients/IGitExtendedHttpClient.cs → CSharp/TfsCmdlets.Shared/HttpClients/IGitExtendedHttpClient.cs

@@ -3,7 +3,7 @@
 namespace TfsCmdlets.HttpClients
 {
     [HttpClient(typeof(GitExtendedHttpClient))]
-    partial interface IGitExtendedHttpClient
+    public partial interface IGitExtendedHttpClient
     {
     }
 }

CSharp/TfsCmdlets/HttpClients/IGitHttpClient.cs → CSharp/TfsCmdlets.Shared/HttpClients/IGitHttpClient.cs

@@ -3,7 +3,7 @@
 namespace TfsCmdlets.HttpClients
 {
     [HttpClient(typeof(GitHttpClient))]
-    partial interface IGitHttpClient
+    public partial interface IGitHttpClient
     {
     }
 }

CSharp/TfsCmdlets/HttpClients/IGraphHttpClient.cs → CSharp/TfsCmdlets.Shared/HttpClients/IGraphHttpClient.cs

@@ -3,7 +3,7 @@
 namespace TfsCmdlets.HttpClients
 {
     [HttpClient(typeof(GraphHttpClient))]
-    partial interface IGraphHttpClient
+    public partial interface IGraphHttpClient
     {
     }
 }

CSharp/TfsCmdlets/HttpClients/IIdentityHttpClient.cs → CSharp/TfsCmdlets.Shared/HttpClients/IIdentityHttpClient.cs

@@ -3,7 +3,7 @@
 namespace TfsCmdlets.HttpClients
 {
     [HttpClient(typeof(IdentityHttpClient))]
-    partial interface IIdentityHttpClient
+    public partial interface IIdentityHttpClient
     {
     }
 }

CSharp/TfsCmdlets/HttpClients/IOperationsHttpClient.cs → CSharp/TfsCmdlets.Shared/HttpClients/IOperationsHttpClient.cs

@@ -3,7 +3,7 @@
 namespace TfsCmdlets.HttpClients {
 
     [HttpClient(typeof(OperationsHttpClient))]
-    partial interface IOperationsHttpClient {
+    public partial interface IOperationsHttpClient {
 
     }
 }

CSharp/TfsCmdlets/HttpClients/IPolicyHttpClient.cs → CSharp/TfsCmdlets.Shared/HttpClients/IPolicyHttpClient.cs

@@ -3,7 +3,7 @@
 namespace TfsCmdlets.HttpClients
 {
     [HttpClient(typeof(PolicyHttpClient))]
-    partial interface IPolicyHttpClient
+    public partial interface IPolicyHttpClient
     {
     }
 }

CSharp/TfsCmdlets/HttpClients/IProcessHttpClient.cs → CSharp/TfsCmdlets.Shared/HttpClients/IProcessHttpClient.cs

@@ -3,7 +3,7 @@
 namespace TfsCmdlets.HttpClients
 {
     [HttpClient(typeof(ProcessHttpClient))]
-    partial interface IProcessHttpClient {
+    public partial interface IProcessHttpClient {
 
     }
 }

CSharp/TfsCmdlets/HttpClients/IProjectHttpClient.cs → CSharp/TfsCmdlets.Shared/HttpClients/IProjectHttpClient.cs

@@ -3,7 +3,7 @@
 namespace TfsCmdlets.HttpClients
 {
     [HttpClient(typeof(ProjectHttpClient))]
-    partial interface IProjectHttpClient
+    public partial interface IProjectHttpClient
     {
     }
 }

CSharp/TfsCmdlets/HttpClients/IReleaseHttpClient.cs → CSharp/TfsCmdlets.Shared/HttpClients/IReleaseHttpClient.cs

@@ -3,7 +3,7 @@
 namespace TfsCmdlets.HttpClients
 {
     [HttpClient(typeof(ReleaseHttpClient))]
-    partial interface IReleaseHttpClient
+    public partial interface IReleaseHttpClient
     {
     }
 }

CSharp/TfsCmdlets/HttpClients/IReleaseHttpClient2.cs → CSharp/TfsCmdlets.Shared/HttpClients/IReleaseHttpClient2.cs

@@ -3,7 +3,7 @@
 namespace TfsCmdlets.HttpClients
 {
     [HttpClient(typeof(ReleaseHttpClient2))]
-    partial interface IReleaseHttpClient2
+    public partial interface IReleaseHttpClient2
     {
     }
 }

CSharp/TfsCmdlets/HttpClients/ISearchHttpClient.cs → CSharp/TfsCmdlets.Shared/HttpClients/ISearchHttpClient.cs

@@ -3,7 +3,7 @@
 namespace TfsCmdlets.HttpClients
 {
     [HttpClient(typeof(SearchHttpClient))]
-    partial interface ISearchHttpClient
+    public partial interface ISearchHttpClient
     {
     }
 }

CSharp/TfsCmdlets/HttpClients/IServiceHooksPublisherHttpClient.cs → CSharp/TfsCmdlets.Shared/HttpClients/IServiceHooksPublisherHttpClient.cs

@@ -3,7 +3,7 @@
 namespace TfsCmdlets.HttpClients
 {
     [HttpClient(typeof(ServiceHooksPublisherHttpClient))]
-    partial interface IServiceHooksPublisherHttpClient
+    public partial interface IServiceHooksPublisherHttpClient
     {
     }
 }

CSharp/TfsCmdlets/HttpClients/ITaggingHttpClient.cs → CSharp/TfsCmdlets.Shared/HttpClients/ITaggingHttpClient.cs

@@ -3,7 +3,7 @@
 namespace TfsCmdlets.HttpClients
 {
     [HttpClient(typeof(TaggingHttpClient))]
-    partial interface ITaggingHttpClient
+    public partial interface ITaggingHttpClient
     {
     }
 }

CSharp/TfsCmdlets/HttpClients/ITeamAdminHttpClient.cs → CSharp/TfsCmdlets.Shared/HttpClients/ITeamAdminHttpClient.cs

@@ -3,7 +3,7 @@
 namespace TfsCmdlets.HttpClients
 {
     [HttpClient(typeof(TeamAdminHttpClient))]
-    partial interface ITeamAdminHttpClient
+    public partial interface ITeamAdminHttpClient
     {
     }
 

CSharp/TfsCmdlets/HttpClients/ITeamHttpClient.cs → CSharp/TfsCmdlets.Shared/HttpClients/ITeamHttpClient.cs

@@ -3,7 +3,7 @@
 namespace TfsCmdlets.HttpClients {
 
     [HttpClient(typeof(TeamHttpClient))]
-    partial interface ITeamHttpClient
+    public partial interface ITeamHttpClient
     {
     }
 }