Skip to content

Refactor Source Generator#253

Open
igoravl wants to merge 58 commits into
mainfrom
refactor-src-gen
Open

Refactor Source Generator#253
igoravl wants to merge 58 commits into
mainfrom
refactor-src-gen

Merge branch 'main' into refactor-src-gen

2dddcfb
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis failed Apr 9, 2026 in 22s

Quality Gate failed

Annotations

Check warning on line 76 in CSharp/TfsCmdlets.SourceGenerators/ClassInfo.cs

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Make 'GetProperties' a static method.

See more on https://sonarcloud.io/project/issues?id=igoravl_TfsCmdlets&issues=AZ0xDegBP8bj0kFn1OR6&open=AZ0xDegBP8bj0kFn1OR6&pullRequest=253

Check warning on line 70 in CSharp/TfsCmdlets.SourceGenerators/PropertyInfo.cs

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Extract this nested ternary operation into an independent statement.

See more on https://sonarcloud.io/project/issues?id=igoravl_TfsCmdlets&issues=AZ0xDegtP8bj0kFn1OSP&open=AZ0xDegtP8bj0kFn1OSP&pullRequest=253

Check warning on line 374 in CSharp/TfsCmdlets.SourceGenerators/HashCode.cs

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Do not forget to remove this deprecated code someday.

See more on https://sonarcloud.io/project/issues?id=igoravl_TfsCmdlets&issues=AZ0xDegMP8bj0kFn1OSH&open=AZ0xDegMP8bj0kFn1OSH&pullRequest=253

Check failure on line 20 in CSharp/TfsCmdlets.Shared/Models/IdentityRefWrapper.cs

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Review this cast; in this project there's no type that extends 'Microsoft.VisualStudio.Services.WebApi.IdentityRef' and implements 'System.Xml.Serialization.IXmlSerializable'.

See more on https://sonarcloud.io/project/issues?id=igoravl_TfsCmdlets&issues=AZ1xNjh1TQrzfiB8qrmN&open=AZ1xNjh1TQrzfiB8qrmN&pullRequest=253

Check warning on line 47 in CSharp/TfsCmdlets.SourceGenerators/Extensions.cs

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Change this condition so that it does not always evaluate to 'False'.

See more on https://sonarcloud.io/project/issues?id=igoravl_TfsCmdlets&issues=AZ0xDegjP8bj0kFn1OSO&open=AZ0xDegjP8bj0kFn1OSO&pullRequest=253

Check warning on line 72 in CSharp/TfsCmdlets.SourceGenerators/Generators/Controllers/ControllerInfo.cs

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Make 'ConvertToArgValues' a static method.

See more on https://sonarcloud.io/project/issues?id=igoravl_TfsCmdlets&issues=AZ0xDeekP8bj0kFn1ORp&open=AZ0xDeekP8bj0kFn1ORp&pullRequest=253

Check failure on line 376 in CSharp/TfsCmdlets.SourceGenerators/HashCode.cs

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this 'throw' expression.

See more on https://sonarcloud.io/project/issues?id=igoravl_TfsCmdlets&issues=AZ0xDegMP8bj0kFn1OSF&open=AZ0xDegMP8bj0kFn1OSF&pullRequest=253

Check warning on line 226 in CSharp/TfsCmdlets.SourceGenerators/Generators/Controllers/ControllerInfo.cs

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Make 'GenerateCredentialProperties' a static method.

See more on https://sonarcloud.io/project/issues?id=igoravl_TfsCmdlets&issues=AZ0xDeekP8bj0kFn1ORq&open=AZ0xDeekP8bj0kFn1ORq&pullRequest=253

Check warning on line 160 in CSharp/TfsCmdlets.SourceGenerators/ClassInfo.cs

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Make 'GetImportingConstructorBody' a static method.

See more on https://sonarcloud.io/project/issues?id=igoravl_TfsCmdlets&issues=AZ0xDegBP8bj0kFn1OR9&open=AZ0xDegBP8bj0kFn1OR9&pullRequest=253

Check failure on line 41 in CSharp/TfsCmdlets.SourceGenerators/ClassInfo.cs

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this call from a constructor to the overridable 'GetCtorArgs' method.

See more on https://sonarcloud.io/project/issues?id=igoravl_TfsCmdlets&issues=AZ0xDegBP8bj0kFn1OR7&open=AZ0xDegBP8bj0kFn1OR7&pullRequest=253

Check warning on line 32 in CSharp/TfsCmdlets.SourceGenerators/Extensions.cs

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

All 'GetAttributeNamedValue' method overloads should be adjacent.

See more on https://sonarcloud.io/project/issues?id=igoravl_TfsCmdlets&issues=AZ0xDegjP8bj0kFn1OSN&open=AZ0xDegjP8bj0kFn1OSN&pullRequest=253

Check failure on line 56 in CSharp/TfsCmdlets.SourceGenerators/Generators/Controllers/ControllerInfo.cs

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this call from a constructor to the overridable 'GetCtorArgs' method.

See more on https://sonarcloud.io/project/issues?id=igoravl_TfsCmdlets&issues=AZ0xDeekP8bj0kFn1ORv&open=AZ0xDeekP8bj0kFn1ORv&pullRequest=253

Check warning on line 223 in CSharp/TfsCmdlets.SourceGenerators/Extensions.cs

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this commented out code.

See more on https://sonarcloud.io/project/issues?id=igoravl_TfsCmdlets&issues=AZ0xDegjP8bj0kFn1OSL&open=AZ0xDegjP8bj0kFn1OSL&pullRequest=253

Check warning on line 188 in CSharp/TfsCmdlets.SourceGenerators/Extensions.cs

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this commented out code.

See more on https://sonarcloud.io/project/issues?id=igoravl_TfsCmdlets&issues=AZ0xDegjP8bj0kFn1OSK&open=AZ0xDegjP8bj0kFn1OSK&pullRequest=253

Check warning on line 1 in CSharp/TfsCmdlets.SourceGenerators/Logger.cs

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this commented out code.

See more on https://sonarcloud.io/project/issues?id=igoravl_TfsCmdlets&issues=AZ0xDef3P8bj0kFn1OR4&open=AZ0xDef3P8bj0kFn1OR4&pullRequest=253

Check warning on line 123 in CSharp/TfsCmdlets.SourceGenerators/HashCode.cs

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Reduce the number of generic parameters in the 'HashCode.Combine' method to no more than the 3 authorized.

See more on https://sonarcloud.io/project/issues?id=igoravl_TfsCmdlets&issues=AZ0xDegMP8bj0kFn1OSA&open=AZ0xDegMP8bj0kFn1OSA&pullRequest=253

Check warning on line 162 in CSharp/TfsCmdlets.SourceGenerators/Extensions.cs

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this commented out code.

See more on https://sonarcloud.io/project/issues?id=igoravl_TfsCmdlets&issues=AZ0xDegjP8bj0kFn1OSJ&open=AZ0xDegjP8bj0kFn1OSJ&pullRequest=253

Check warning on line 38 in CSharp/TfsCmdlets.SourceGenerators/MethodInfo.cs

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Extract this nested ternary operation into an independent statement.

See more on https://sonarcloud.io/project/issues?id=igoravl_TfsCmdlets&issues=AZ0xDeeSP8bj0kFn1ORj&open=AZ0xDeeSP8bj0kFn1ORj&pullRequest=253

Check warning on line 69 in CSharp/TfsCmdlets.SourceGenerators/Extensions.cs

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this commented out code.

See more on https://sonarcloud.io/project/issues?id=igoravl_TfsCmdlets&issues=AZ0xDegjP8bj0kFn1OSI&open=AZ0xDegjP8bj0kFn1OSI&pullRequest=253

Check warning on line 111 in CSharp/TfsCmdlets.SourceGenerators/Generators/Cmdlets/CmdletInfo.cs

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Define a constant instead of using this literal 'SwitchParameter' 4 times.

See more on https://sonarcloud.io/project/issues?id=igoravl_TfsCmdlets&issues=AZ1xNjoNTQrzfiB8qrmQ&open=AZ1xNjoNTQrzfiB8qrmQ&pullRequest=253

Check warning on line 370 in CSharp/TfsCmdlets.SourceGenerators/HashCode.cs

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Do not forget to remove this deprecated code someday.

See more on https://sonarcloud.io/project/issues?id=igoravl_TfsCmdlets&issues=AZ0xDegMP8bj0kFn1OSG&open=AZ0xDegMP8bj0kFn1OSG&pullRequest=253

Check warning on line 16 in CSharp/TfsCmdlets.SourceGenerators/Generators/Cmdlets/ParameterInfo.cs

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Complete the task associated to this 'TODO' comment.

See more on https://sonarcloud.io/project/issues?id=igoravl_TfsCmdlets&issues=AZ0xDee4P8bj0kFn1ORy&open=AZ0xDee4P8bj0kFn1ORy&pullRequest=253

Check warning on line 168 in CSharp/TfsCmdlets.SourceGenerators/Generators/Cmdlets/CmdletInfo.cs

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Make 'GenerateCredentialProperties' a static method.

See more on https://sonarcloud.io/project/issues?id=igoravl_TfsCmdlets&issues=AZ0xDefMP8bj0kFn1OR1&open=AZ0xDefMP8bj0kFn1OR1&pullRequest=253

Check warning on line 22 in CSharp/TfsCmdlets.Shared/Cmdlets/WorkItem/Tagging/ToggleWorkItemTagController.cs

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

This line will not be executed conditionally; only the first line of this 5-line block will be. The rest will execute unconditionally.

See more on https://sonarcloud.io/project/issues?id=igoravl_TfsCmdlets&issues=AZ0xDeaCP8bj0kFn1OQ_&open=AZ0xDeaCP8bj0kFn1OQ_&pullRequest=253

Check warning on line 42 in CSharp/TfsCmdlets/Cmdlets/TestManagement/GetTestPlan.cs

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Split this method into two, one handling parameters check and the other handling the iterator.

See more on https://sonarcloud.io/project/issues?id=igoravl_TfsCmdlets&issues=AZ0xDecvP8bj0kFn1ORf&open=AZ0xDecvP8bj0kFn1ORf&pullRequest=253