Skip to content

Add enableFakechroot option for image generation #284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
HolmDev wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add enableFakechroot option for image generation #284

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 12 additions & 3 deletions src/nix/modules/service/image.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ let
{
name = null; tag = null; contents = null; config = null;
created = null; extraCommands = null; maxLayers = null;
fakeRootCommands = null;
fakeRootCommands = null; enableFakechroot = null;
}
args;
acceptedArgs = functionArgs dockerTools.streamLayeredImage;
Expand All @@ -50,6 +50,8 @@ let
name
contents
includeStorePaths
fakeRootCommands
enableFakechroot
;
config = config.image.rawConfig;
maxLayers = 100;
Expand All @@ -68,8 +70,6 @@ let
ln -s $i nix/var/nix/gcroots/docker/$(basename $i)
done;
'';

fakeRootCommands = config.image.fakeRootCommands;
};

priorityIsDefault = option: option.highestPrio >= (lib.mkDefault true).priority;
Expand Down Expand Up @@ -132,6 +132,15 @@ in
See [`dockerTools.buildLayeredImage`](https://nixos.org/manual/nixpkgs/stable/#ssec-pkgs-dockerTools-buildLayeredImage).
'';
};
image.enableFakechroot = mkOption {
type = bool;
default = false;
description = ''
Runs the commands from `image.fakeRootCommands` in a complete fakechroot environment instead of fakeroot. This allows installation in `/` to work as expected, similar to the instruction [`RUN`](https://docs.docker.com/reference/dockerfile/#run).

See [`dockerTools.buildLayeredImage`](https://nixos.org/manual/nixpkgs/stable/#ssec-pkgs-dockerTools-buildLayeredImage).
'';
};
image.includeStorePaths = mkOption {
type = bool;
default = true;
Expand Down