Add enableFakechroot option for image generation#284
Open
HolmDev wants to merge 1 commit intohercules-ci:mainfrom
Open
Add enableFakechroot option for image generation#284HolmDev wants to merge 1 commit intohercules-ci:mainfrom
HolmDev wants to merge 1 commit intohercules-ci:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To begin with, very nice project! I can't state how much I appreciate not having to write YAML.
This is quite a minor edit, but I found it quite peculiar that
enableFakechrootfromdockerTools.{build,stream}LayeredImagewasn't available in theimageoptions. This kept me from running commands such asmkdir -p /var/libinfakeRootCommandswhen using some attribute sets for images that I have previously used when usingdockerTools.streamLayeredImage.This PR simply adds that option and passes it to
buildOrStreamLayeredImage.If there is a obvious reason for its absence which I have not realized, I apologize. I am quite new to the Nix ecosystem.
PS. This would of course (sort of) be addressed in #92 since that would enable us to simply use our image archive derivations from
dockerTools.streamLayeredImage, etc, instead of adding each option from them.