Skip to content

exec, query: factor out common parameter handling helpers#23

Closed
robx wants to merge 1 commit into
haskellari:masterfrom
robx:refactor-params
Closed

exec, query: factor out common parameter handling helpers#23
robx wants to merge 1 commit into
haskellari:masterfrom
robx:refactor-params

Conversation

@robx
Copy link
Copy Markdown
Contributor

@robx robx commented Jul 4, 2022

There were two identical copies each of the parameter mangling code.

First change from #22.

There were two identical copies each of the parameter mangling
code.
@phadej
Copy link
Copy Markdown
Collaborator

phadej commented Jul 20, 2022

Is that what you had in mind?

Yes.

But looking at the code, I want to clean up it further, and it's easier to me to do it than try to explain. So I'll do it at some time in the future (around when GHC-9.4 is released the latest).

@robx
Copy link
Copy Markdown
Contributor Author

robx commented Aug 29, 2022

But looking at the code, I want to clean up it further, and it's easier to me to do it than try to explain. So I'll do it at some time in the future (around when GHC-9.4 is released the latest).

Did you get a chance to look at this?

@phadej
Copy link
Copy Markdown
Collaborator

phadej commented Nov 3, 2022

Sorry for huge delay. I finally made some time to look after posgresql-libpq. Merged this in #30 with few cleanups. Let's get binary params stuff sorted.

In meantime I'll drop GHC-7 support.

@phadej phadej closed this Nov 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants