simplify withParams helpers#1
Closed
robx wants to merge 2 commits into
Closed
Conversation
Instead of building a list of 'Int' in the fold, and then mapping 'toEnum' over it, build a list of 'CInt' directly.
We encode various arrays of the same length through 'withArray'. Each of these computes the length, so we might as well take the length from one of these.
Owner
Author
|
This has been fixed upstream. |
robx
added a commit
that referenced
this pull request
Mar 8, 2023
Avoid copies when passing binary parameters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes the code a bit more concise, and maybe saves a bit of work.
Second part of haskellari#22, on top of haskellari#23. (Will probably need to refile this against haskellari/postgresql-libpq once 22 is done.)