Skip to content

Remove uopz PHP extension and refactor guard tests #12398

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
officialasishkumar wants to merge 2 commits into
base: develop
Choose a base branch
from
+33 −27
Open

Remove uopz PHP extension and refactor guard tests #12398

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ede2740
Remove uopz PHP extension from CI and refactor guard tests.
officialasishkumar Mar 28, 2026
08059ed
Merge branch 'develop' into infrastructure/12332-remove-uopz-extension
aaemnnosttv Apr 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/gemini.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ jobs:
uses: shivammathur/setup-php@v2
with:
php-version: "8.4"
extensions: mysqli, uopz
extensions: mysqli
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
- name: Get Composer Cache Directory
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/php-lint-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -191,7 +191,7 @@ jobs:
- name: Setup PHP for Tests
uses: shivammathur/setup-php@v2
with:
extensions: mysqli, uopz
extensions: mysqli
php-version: ${{ matrix.php_version }}
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
Expand Down
56 changes: 31 additions & 25 deletions tests/phpunit/integration/Core/Tags/Guards/Tag_Environment_Type_GuardTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,11 @@

class Tag_Environment_Type_GuardTest extends TestCase {

public function tear_down() {
remove_all_filters( 'googlesitekit_allowed_tag_environment_types' );
parent::tear_down();
}

public function test_can_activate_on_post_5_5_version() {
if ( ! function_exists( 'wp_get_environment_type' ) ) {
// This environment is pre WP-5.5.0 and is skipped.
Expand All @@ -33,44 +38,45 @@ public function test_can_activate_on_older_versions() {
$this->assertTrue( $tagproduction->can_activate(), 'Tag should be able to activate on older versions.' );
}

public function test_can_not_activate_in_development() {
// Pre WP-5.5.0
public function test_can_not_activate_when_environment_not_allowed() {
if ( ! function_exists( 'wp_get_environment_type' ) ) {
$this->markTestSkipped( 'Missing wp_get_environment_type() function.' );
}
if ( ! function_exists( 'uopz_set_static' ) ) {
$this->markTestSkipped( 'The uopz extension is not available.' );
}
$env_type = wp_get_environment_type();
$tagproduction = new Tag_Environment_Type_Guard();
uopz_set_static( 'wp_get_environment_type', array( 'current_env' => 'development' ) );
$this->assertFalse( $tagproduction->can_activate(), 'Tag should not be able to activate in development environment.' );
uopz_set_static( 'wp_get_environment_type', array( 'current_env' => $env_type ) );

$current_env = wp_get_environment_type();

add_filter(
'googlesitekit_allowed_tag_environment_types',
function () use ( $current_env ) {
return array_values(
array_diff( array( 'local', 'development', 'staging', 'production' ), array( $current_env ) )
);
}
);

$this->assertFalse(
( new Tag_Environment_Type_Guard() )->can_activate(),
'Tag should not activate when the current environment is excluded from the allowed list.'
);
}

public function test_can_activate_in_development() {
// Pre WP-5.5.0
public function test_can_activate_when_environment_is_allowed() {
if ( ! function_exists( 'wp_get_environment_type' ) ) {
$this->markTestSkipped( 'Missing wp_get_environment_type() function.' );
}
if ( ! function_exists( 'uopz_set_static' ) ) {
$this->markTestSkipped( 'The uopz extension is not available.' );
}
$env_type = wp_get_environment_type();
$tagproduction = new Tag_Environment_Type_Guard();
uopz_set_static( 'wp_get_environment_type', array( 'current_env' => 'development' ) );
$this->assertFalse( $tagproduction->can_activate(), 'Tag should not be able to activate in development environment by default.' );

remove_all_filters( 'googlesitekit_allowed_tag_environment_types' );
$current_env = wp_get_environment_type();

add_filter(
'googlesitekit_allowed_tag_environment_types',
function ( $allowed_environments ) {
$allowed_environments[] = 'development';
return $allowed_environments;
function () use ( $current_env ) {
return array( $current_env );
}
);
$this->assertTrue( $tagproduction->can_activate(), 'Tag should be able to activate in development environment when allowed.' );

uopz_set_static( 'wp_get_environment_type', array( 'current_env' => $env_type ) );
$this->assertTrue(
( new Tag_Environment_Type_Guard() )->can_activate(),
'Tag should activate when the current environment is in the allowed list.'
);
}
}