Remove uopz PHP extension and refactor guard tests#12398
Open
officialasishkumar wants to merge 1 commit intogoogle:developfrom
Open
Remove uopz PHP extension and refactor guard tests#12398officialasishkumar wants to merge 1 commit intogoogle:developfrom
officialasishkumar wants to merge 1 commit intogoogle:developfrom
Conversation
Drop the uopz extension from the php-lint-tests and gemini CI workflows as no tests depend on it after this change. Refactor Tag_Environment_Type_GuardTest to use the existing googlesitekit_allowed_tag_environment_types filter instead of uopz_set_static for mocking the environment type. This makes the tests portable across all PHP versions without requiring any additional extensions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Addresses issue:
uopzextension in tests #12332Relevant technical choices
CI workflows: Removed
uopzfrom the PHP extension lists in bothphp-lint-tests.ymlandgemini.yml. No tests depend on it after this change.Test refactoring (
Tag_Environment_Type_GuardTest): Replaced alluopz_set_staticcalls with filter-based assertions using the existinggooglesitekit_allowed_tag_environment_typesfilter:test_can_not_activate_when_environment_not_allowed: Filters allowed environments to exclude the current environment type, then asserts the guard rejects activation.test_can_activate_when_environment_is_allowed: Filters allowed environments to include only the current environment type, then asserts the guard permits activation.This approach tests the same guard logic without requiring any additional PHP extensions. A
tear_downmethod clears the filter between tests to prevent leakage.The two existing pre-5.5 / post-5.5 WP version tests are preserved unchanged.
PR Author Checklist
Do not alter or remove anything below. The following sections will be managed by moderators only.
Code Reviewer Checklist
Merge Reviewer Checklist