feat: support optional finding of externals instead of subdirectories#8266
Closed
aminya wants to merge 1 commit intogoogle:mainfrom
Closed
feat: support optional finding of externals instead of subdirectories#8266aminya wants to merge 1 commit intogoogle:mainfrom
aminya wants to merge 1 commit intogoogle:mainfrom
Conversation
Contributor
Contributor
Author
|
@poweifeng The PR was ready to be reviewed. There are multiple issues requesting this already. Could you reopen it? I'll make sure all the CI failures are addressed. |
Contributor
|
Big thumbs-up from me for this PR - it looks like the best solution allowing to keep the modules in add_subdirectory for the people who want and use filament as a submodule/subdirectory, but will also allow a much smoother, better CMake experience for everyone else using find_package and/or a package manager. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5957
This adds an option to allow usage of external targets that are found via
find_packageandfind_pathinstead of adding them viaadd_subdirectory. The implementation will fallback to the directories if a target/header cannot be found.This is cherry-picked from my PR for allowing filament to be built via vcpkg:
microsoft/vcpkg#41916