Skip to content

feat: add options to disable tests/benchmarks#8245

Closed
aminya wants to merge 2 commits intogoogle:mainfrom
aminya:tests-benchmarks
Closed

feat: add options to disable tests/benchmarks#8245
aminya wants to merge 2 commits intogoogle:mainfrom
aminya:tests-benchmarks

Conversation

@aminya
Copy link
Copy Markdown
Contributor

@aminya aminya commented Nov 1, 2024

When building Filament from the source for production from a package manager like vcpkg, these options allow turning off the tests and benchmarks that are not needed for using the library. This significantly reduces compilation time.

Note that I didn't indent the ifs for a smaller diff to make it easier to review, but I can do that if needed.

This is cherry-picked from my PR for allowing filament to be built via vcpkg:
microsoft/vcpkg#41916

@pixelflinger
Copy link
Copy Markdown
Collaborator

what is the reason for this PR?

@aminya
Copy link
Copy Markdown
Contributor Author

aminya commented Nov 1, 2024

When building Filament from the source for production from a package manager like vcpkg, these options allow turning off the tests and benchmarks that are not needed for using the library. This significantly reduces compilation time. @pixelflinger

@aminya
Copy link
Copy Markdown
Contributor Author

aminya commented Nov 10, 2024

Note that I didn't indent the ifs for a smaller diff to make it easier to review, but I can do that if needed.

@poweifeng
Copy link
Copy Markdown
Contributor

Closing due to this PR having been idle for a while. If you'd like to continue, would you mind first opening a feature request issue and we can have a discussion there to better understand the need?
(related PRs #8267 #8266 #8245)

@poweifeng poweifeng closed this Mar 7, 2025
@aminya
Copy link
Copy Markdown
Contributor Author

aminya commented Mar 10, 2025

@poweifeng The PR was ready to be reviewed. Could you tell me if you expected a specific activity?

@patrikhuber
Copy link
Copy Markdown
Contributor

Also a thumbs up from me here, this is useful for the reasons mentioned by @aminya.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants