Adds type_annotations back but as a relocation to annotations#4906
Closed
tbroyer wants to merge 1 commit intogoogle:masterfrom
Closed
Adds type_annotations back but as a relocation to annotations#4906tbroyer wants to merge 1 commit intogoogle:masterfrom
tbroyer wants to merge 1 commit intogoogle:masterfrom
Conversation
Adds a dependency to type_annotations into annotations to make sure it'll "update" an older type_annotations dependency present in the same "bag" of dependencies (works best in Gradle; Maven having a "nearest definition" rule so won't always work but hopefully people align versions one way or another).
Contributor
Author
|
With Gradle, the relocation (being always present in the resolution) will print a note when run with With Maven, it'll only generate a warning if the type_annotations is directly present in the pom.xml (from my tests) |
cushon
approved these changes
Mar 17, 2025
copybara-service Bot
pushed a commit
that referenced
this pull request
Mar 17, 2025
Adds a dependency to type_annotations into annotations to make sure it'll "update" an older type_annotations dependency present in the same "bag" of dependencies (works best in Gradle; Maven having a "nearest definition" rule so won't always work but hopefully people align versions one way or another). Fixes #4906 FUTURE_COPYBARA_INTEGRATE_REVIEW=#4906 from tbroyer:type_annotations-relocation 31c2f10 PiperOrigin-RevId: 737627376
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a dependency to type_annotations into annotations to make sure it'll "update" an older type_annotations dependency present in the same "bag" of dependencies (works best in Gradle; Maven having a "nearest definition" rule so won't always work but hopefully people align versions one way or another).