Skip to content

Remove separate type_annotations artifact#4904

Merged
copybara-service[bot] merged 1 commit intomasterfrom
test_736931842
Mar 17, 2025
Merged

Remove separate type_annotations artifact#4904
copybara-service[bot] merged 1 commit intomasterfrom
test_736931842

Conversation

@copybara-service
Copy link
Copy Markdown
Contributor

Remove separate type_annotations artifact

And merge type_annotations in annotations. The annotations artifact is still Java 8 compatible.

The type_annotations artifact was created when annotations was Java 7-compatible, to allow using Java 8 annotation APIs (like @Target(TYPE_USE)).

This avoids split package issues when using Error Prone annotations from modularized builds, see e.g. #4888

Tested:
TAP for global presubmit queue
[]

@tbroyer
Copy link
Copy Markdown
Contributor

tbroyer commented Mar 17, 2025

The type_annotation artifact should be kept as a relocation, at least for the next or a few versions.

And merge type_annotations in annotations. The annotations artifact is still Java 8 compatible.

The type_annotations artifact was created when annotations was Java 7-compatible, to allow using Java 8 annotation APIs (like `@Target(TYPE_USE)`).

This avoids split package issues when using Error Prone annotations from modularized builds, see e.g. #4888

Tested:
    TAP for global presubmit queue
    []
PiperOrigin-RevId: 737500755
@copybara-service copybara-service Bot merged commit c124fc6 into master Mar 17, 2025
@copybara-service copybara-service Bot deleted the test_736931842 branch March 17, 2025 06:42
@tbroyer
Copy link
Copy Markdown
Contributor

tbroyer commented Mar 17, 2025

The type_annotation artifact should be kept as a relocation, at least for the next or a few versions.

Opened #4906

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants