Remove separate type_annotations artifact#4904
Merged
copybara-service[bot] merged 1 commit intomasterfrom Mar 17, 2025
Merged
Conversation
Contributor
|
The type_annotation artifact should be kept as a relocation, at least for the next or a few versions. |
And merge type_annotations in annotations. The annotations artifact is still Java 8 compatible. The type_annotations artifact was created when annotations was Java 7-compatible, to allow using Java 8 annotation APIs (like `@Target(TYPE_USE)`). This avoids split package issues when using Error Prone annotations from modularized builds, see e.g. #4888 Tested: TAP for global presubmit queue [] PiperOrigin-RevId: 737500755
9923147 to
c124fc6
Compare
Contributor
Opened #4906 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove separate type_annotations artifact
And merge type_annotations in annotations. The annotations artifact is still Java 8 compatible.
The type_annotations artifact was created when annotations was Java 7-compatible, to allow using Java 8 annotation APIs (like
@Target(TYPE_USE)).This avoids split package issues when using Error Prone annotations from modularized builds, see e.g. #4888
Tested:
TAP for global presubmit queue
[]