Skip to content

(Lit) Add restaurant sample v0.9#1105

Draft
ditman wants to merge 41 commits intogoogle:mainfrom
ditman:lite-restaurant-sample-v09
Draft

(Lit) Add restaurant sample v0.9#1105
ditman wants to merge 41 commits intogoogle:mainfrom
ditman:lite-restaurant-sample-v09

Conversation

@ditman
Copy link
Copy Markdown
Collaborator

@ditman ditman commented Apr 9, 2026

Description

This PR builds on top of #1079 and ports the "shell" app to use the v0.9 renderer.

Issues

Pre-launch Checklist

If you need help, consider asking for advice on the discussion board.

@ditman
Copy link
Copy Markdown
Collaborator Author

ditman commented Apr 9, 2026

(Everything outside "samples" is covered by a separate PR, feel free to ignore those)

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the A2UI Lit renderer for version 0.9.0, introducing a centralized theming system and migrating components from inline styles to CSS variables. It includes a new v0.9 sample shell and updates to the web_core package to support shared design tokens. Review feedback suggests removing unnecessary placeholder characters in the Divider, adopting declarative style bindings in the Image component, cleaning up unused imports, adding missing type annotations, and consolidating flex-weight logic in the base class to avoid redundancy. Additionally, it was noted that static class names should be used instead of classMap for better performance in the Icon component.

</section>`;
}

async #sendAndProcessMessage(request) {
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The request parameter is missing a type annotation. Adding a type (e.g., any or a more specific interface if available) improves type safety and developer experience in this TypeScript project.

Suggested change
async #sendAndProcessMessage(request) {
async #sendAndProcessMessage(request: any) {

@ditman ditman mentioned this pull request Apr 9, 2026
6 tasks
@ditman ditman requested review from ava-cassiopeia and dmandar April 9, 2026 17:58
@ditman ditman force-pushed the lite-restaurant-sample-v09 branch 2 times, most recently from 1410979 to af315a5 Compare April 10, 2026 03:13
@ditman ditman force-pushed the lite-restaurant-sample-v09 branch from af315a5 to 0729efe Compare April 10, 2026 18:26
@ditman ditman force-pushed the lite-restaurant-sample-v09 branch from 0729efe to 9aec40e Compare April 11, 2026 00:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Todo

Development

Successfully merging this pull request may close these issues.

1 participant