Open
Conversation
ditman
commented
Apr 2, 2026
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a default theme system for A2UI, including a new theme injection utility and CSS variable definitions. The Button and Text components across the basic and minimal catalogs have been updated to utilize these styles. Feedback points out a critical SSR compatibility issue where the document object is accessed without a check, an inconsistent fallback color for button hovers, and significant code duplication between catalogs that should be refactored into shared utilities or base classes.
The function allows basic catalog implementations to inject a shared stylesheet that contains a set of overridable variables used by the widgets to keep the styling somewhat consistent.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is some initial work for the CSS styling of the v0.9 of the renderers. On this version, only the "Button" component is styled.
The idea is to give global CSS variables that users can control in a more or less granular fashion, and some widget-defined variables.
The only widget I've really touched so far is the Lit Button, as a PoC. It is eyeball tested in the v0.9 gallery sample app for now.
Pre-launch Checklist
If you need help, consider asking for advice on the discussion board.