Skip to content

os/user: return UnknownUserError for ERROR_NONE_MAPPED on Windows#78150

Open
zheliu2 wants to merge 1 commit intogolang:masterfrom
zheliu2:fix/os-user-error-none-mapped
Open

os/user: return UnknownUserError for ERROR_NONE_MAPPED on Windows#78150
zheliu2 wants to merge 1 commit intogolang:masterfrom
zheliu2:fix/os-user-error-none-mapped

Conversation

@zheliu2
Copy link
Copy Markdown

@zheliu2 zheliu2 commented Mar 13, 2026

When user.Lookup is called with a nonexistent user on Windows,
LookupAccountName returns ERROR_NONE_MAPPED (error code 1332).
Currently this raw Windows error propagates to the caller, but the
documentation says Lookup should return UnknownUserError.

This change checks for ERROR_NONE_MAPPED in both lookupUser and
lookupGroupName, returning UnknownUserError and UnknownGroupError
respectively.

Fixes #73595

When LookupAccountName returns ERROR_NONE_MAPPED (error code 1332),
return UnknownUserError instead of the raw Windows error. This aligns
with the documented behavior that Lookup returns UnknownUserError
when the user is not found.

Similarly, return UnknownGroupError from LookupGroup when the group
name cannot be mapped to a security ID.

Fixes golang#73595
@gopherbot
Copy link
Copy Markdown
Contributor

This PR (HEAD: 6f9eb02) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/755060.

Important tips:

  • Don't comment on this PR. All discussion takes place in Gerrit.
  • You need a Gmail or other Google account to log in to Gerrit.
  • To change your code in response to feedback:
    • Push a new commit to the branch used by your GitHub PR.
    • A new "patch set" will then appear in Gerrit.
    • Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
    • Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
    • Multiple commits in the PR will be squashed by GerritBot.
  • The title and description of the GitHub PR are used to construct the final commit message.
    • Edit these as needed via the GitHub web interface (not via Gerrit or git).
    • You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
  • See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

@gopherbot
Copy link
Copy Markdown
Contributor

Message from Gopher Robot:

Patch Set 1:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/755060.
After addressing review feedback, remember to publish your drafts!

@zheliu2 zheliu2 marked this pull request as ready for review March 13, 2026 15:38
@gopherbot
Copy link
Copy Markdown
Contributor

Message from Quim Muntal:

Patch Set 1:

(2 comments)


Please don’t reply on this GitHub thread. Visit golang.org/cl/755060.
After addressing review feedback, remember to publish your drafts!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

os/user: Lookup does not handle windows.ERROR_NONE_MAPPED correctly

2 participants