os/user: return UnknownUserError for ERROR_NONE_MAPPED on Windows#78150
Open
zheliu2 wants to merge 1 commit intogolang:masterfrom
Open
os/user: return UnknownUserError for ERROR_NONE_MAPPED on Windows#78150zheliu2 wants to merge 1 commit intogolang:masterfrom
zheliu2 wants to merge 1 commit intogolang:masterfrom
Conversation
When LookupAccountName returns ERROR_NONE_MAPPED (error code 1332), return UnknownUserError instead of the raw Windows error. This aligns with the documented behavior that Lookup returns UnknownUserError when the user is not found. Similarly, return UnknownGroupError from LookupGroup when the group name cannot be mapped to a security ID. Fixes golang#73595
Contributor
|
This PR (HEAD: 6f9eb02) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/755060. Important tips:
|
Contributor
|
Message from Gopher Robot: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/755060. |
Contributor
|
Message from Quim Muntal: Patch Set 1: (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/755060. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
user.Lookupis called with a nonexistent user on Windows,LookupAccountNamereturnsERROR_NONE_MAPPED(error code 1332).Currently this raw Windows error propagates to the caller, but the
documentation says
Lookupshould returnUnknownUserError.This change checks for
ERROR_NONE_MAPPEDin bothlookupUserandlookupGroupName, returningUnknownUserErrorandUnknownGroupErrorrespectively.
Fixes #73595