[BVH precision] Make scene culling use precision-proof version of BVH::ray_query()#100480
Draft
Flarkk wants to merge 2 commits into
Draft
[BVH precision] Make scene culling use precision-proof version of BVH::ray_query()#100480Flarkk wants to merge 2 commits into
BVH::ray_query()#100480Flarkk wants to merge 2 commits into
Conversation
Flarkk
changed the title
BVH::ray_query()
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up PR of #100475. More context there.
This PR makes sure scene culling uses the numerical precision-proof version of BVH::ray_query().
Note that this PR breaks compatibility as it changes the signature of
RenderingServer::instances_cull_ray(). This is however a function intended for editor usage, so this shouldn't be a hard stop.TODO :