Skip to content

feat: Add Linear action item syncing for incidents #139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
spalmurray wants to merge 17 commits into
base: main
Choose a base branch
from

Add pagination safety guards in get_issues_by_attachment_url

a808bc8
Select commit
Loading
Failed to load commit list.
Open

feat: Add Linear action item syncing for incidents #139

Add pagination safety guards in get_issues_by_attachment_url
a808bc8
Select commit
Loading
Failed to load commit list.
@sentry/warden / warden: code-review completed Apr 7, 2026 in 7m 50s

1 issue

code-review: Found 1 issue (1 medium)

Medium

URL format inconsistency may break Linear attachment matching - `src/firetower/incidents/hooks.py:31`

The changes add trailing slashes to incident URLs in hooks.py (lines 31 and 62) and services.py (line 166), but slack_app/handlers/new_incident.py:315 still constructs URLs without a trailing slash. This inconsistency means the incident URL posted in Slack DMs will not match the URL format used for Linear attachment queries, potentially causing action items to not sync correctly when users attach Linear issues to the Slack-posted link.

Duration: 7m 49s · Tokens: 1.6M in / 20.4k out · Cost: $3.20 (+extraction: $0.00)

Annotations

Check warning on line 31 in src/firetower/incidents/hooks.py

See this annotation in the file changed.

@sentry-warden sentry-warden / warden: code-review

URL format inconsistency may break Linear attachment matching 

The changes add trailing slashes to incident URLs in `hooks.py` (lines 31 and 62) and `services.py` (line 166), but `slack_app/handlers/new_incident.py:315` still constructs URLs without a trailing slash. This inconsistency means the incident URL posted in Slack DMs will not match the URL format used for Linear attachment queries, potentially causing action items to not sync correctly when users attach Linear issues to the Slack-posted link.
View more details on @sentry/warden