Skip to content

Add pagination safety guards in get_issues_by_attachment_url

a808bc8
Select commit
Loading
Failed to load commit list.
Open

feat: Add Linear action item syncing for incidents #139

Add pagination safety guards in get_issues_by_attachment_url
a808bc8
Select commit
Loading
Failed to load commit list.
@sentry/warden / warden completed Apr 7, 2026 in 9m 42s

1 issue

Medium

URL format inconsistency may break Linear attachment matching - `src/firetower/incidents/hooks.py:31`

The changes add trailing slashes to incident URLs in hooks.py (lines 31 and 62) and services.py (line 166), but slack_app/handlers/new_incident.py:315 still constructs URLs without a trailing slash. This inconsistency means the incident URL posted in Slack DMs will not match the URL format used for Linear attachment queries, potentially causing action items to not sync correctly when users attach Linear issues to the Slack-posted link.

5 skills analyzed
Skill Findings Duration Cost
security-review 0 2m 23s $2.83
django-access-review 0 6m 53s $3.43
django-perf-review 0 9m 24s $2.53
code-review 1 7m 49s $3.20
find-bugs 0 4m 59s $6.83

Duration: 31m 29s · Tokens: 8.7M in / 101.4k out · Cost: $18.85 (+extraction: $0.00, +dedup: $0.03)