Skip to content

fix(cli): wrap missing config errors #1325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
resolvicomai wants to merge 1 commit into from
Closed

fix(cli): wrap missing config errors #1325

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cli/config.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ func RunConfig(args []string) error {
}

if _, err := os.Stat(target); os.IsNotExist(err) {
return fmt.Errorf("file not found: %s", target)
return fmt.Errorf("file not found: %s: %w", target, err)
}

cmd := exec.Command(editor, target)
Expand Down
19 changes: 19 additions & 0 deletions cli/config_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
package cli

import (
"errors"
"os"
"testing"
)

func TestRunConfigMissingConfigWrapsNotExist(t *testing.T) {
t.Setenv("HOME", t.TempDir())

err := RunConfig(nil)
if err == nil {
t.Fatal("RunConfig() error = nil, want missing config error")
}
if !errors.Is(err, os.ErrNotExist) {
t.Fatalf("RunConfig() error = %v, want errors.Is(os.ErrNotExist)", err)
}
}
Loading