Skip to content

fix(cli): wrap missing config errors#1325

Open
resolvicomai wants to merge 1 commit into
floatpane:masterfrom
resolvicomai:fix/config-loader-error-wrap
Open

fix(cli): wrap missing config errors#1325
resolvicomai wants to merge 1 commit into
floatpane:masterfrom
resolvicomai:fix/config-loader-error-wrap

Conversation

@resolvicomai
Copy link
Copy Markdown
Contributor

What?

Wrap the underlying os.Stat error when matcha config cannot find the target config/plugin file.

Why?

This preserves errors.Is(err, os.ErrNotExist) for callers while keeping the existing user-facing path in the message.

Closes #690.

Verification

  • go test ./cli -run TestRunConfigMissingConfigWrapsNotExist -count=1
  • go test ./cli
  • go test ./config
  • go test ./...
  • make lint
  • git diff --check

@resolvicomai resolvicomai requested a review from a team as a code owner May 21, 2026 12:42
Copy link
Copy Markdown
Member

@floatpanebot floatpanebot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @resolvicomai! Please fix the following issues with your PR:

  • Title: Is too long (41 characters). The PR title must be strictly under 40 characters.

@floatpanebot floatpanebot added bug Something isn't working area/cli CLI flags / commands size/S Diff: 11–50 lines and removed bug Something isn't working area/cli CLI flags / commands labels May 21, 2026
@resolvicomai resolvicomai changed the title fix(cli): wrap missing config file errors fix(cli): wrap missing config errors May 21, 2026
@floatpanebot floatpanebot dismissed their stale review May 21, 2026 12:43

Formatting issues have been resolved. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working size/S Diff: 11–50 lines

Projects

None yet

Development

Successfully merging this pull request may close these issues.

BUG: Missing error wrapping in config loader

2 participants