Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,7 @@ group :development do

# Pinned to 2.11.0: 2.12.0 intermittently resets the second back-to-back
# `kamal app exec` SSH connection in the pre-deploy hook (Errno::ECONNRESET).
gem "kamal", "2.11.0", require: false
gem "kamal", "2.12.0", require: false
Comment on lines 130 to +132

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 The comment was written specifically to explain why the gem was pinned at 2.11.0, warning that 2.12.0 had the Errno::ECONNRESET bug. Now that the gem is 2.12.0, the comment either describes a live regression (if the bug wasn't fixed upstream) or is stale misleading documentation. Either the comment should be removed because the issue is resolved in 2.12.0, or this upgrade should be held until the upstream fix is confirmed.

Suggested change
# Pinned to 2.11.0: 2.12.0 intermittently resets the second back-to-back
# `kamal app exec` SSH connection in the pre-deploy hook (Errno::ECONNRESET).
gem "kamal", "2.11.0", require: false
gem "kamal", "2.12.0", require: false
gem "kamal", "2.12.0", require: false


gem "letter_opener"
gem "letter_opener_web", "~> 3.0"
Expand Down
4 changes: 2 additions & 2 deletions Gemfile.lock
Original file line number Diff line number Diff line change
Expand Up @@ -350,7 +350,7 @@ GEM
simpleidn (~> 0.2)
jwt (3.2.0)
base64
kamal (2.11.0)
kamal (2.12.0)
activesupport (>= 7.0)
base64 (~> 0.2)
bcrypt_pbkdf (~> 1.0)
Expand Down Expand Up @@ -891,7 +891,7 @@ DEPENDENCIES
irb
jbuilder
js_cookie_rails
kamal (= 2.11.0)
kamal (= 2.12.0)
kaminari
letter_opener
letter_opener_web (~> 3.0)
Expand Down
Binary file removed vendor/cache/kamal-2.11.0.gem
Binary file not shown.
Binary file added vendor/cache/kamal-2.12.0.gem
Binary file not shown.