chore(deps-dev): bump kamal from 2.11.0 to 2.12.0#4166
Conversation
Bumps [kamal](https://github.com/basecamp/kamal) from 2.11.0 to 2.12.0. - [Release notes](https://github.com/basecamp/kamal/releases) - [Commits](basecamp/kamal@v2.11.0...v2.12.0) --- updated-dependencies: - dependency-name: kamal dependency-version: 2.12.0 dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
Bot
added
dependencies
Greptile SummaryThis is a Dependabot-generated bump of the
Confidence Score: 3/5The upgrade itself may be fine, but the retained comment explicitly warns that 2.12.0 carries a known SSH connection reset bug in the pre-deploy hook — if that bug is not fixed upstream, merging this will break deployments. The original pin comment says 2.12.0 has an intermittent Errno::ECONNRESET on back-to-back kamal app exec calls in the pre-deploy hook. Since that comment was left intact, it is unclear whether the team verified the upstream fix or simply accepted an auto-generated bump without review. If the bug is still present, deploys will intermittently fail at the pre-deploy hook step. Gemfile — the stale pin comment needs to be either removed (if the upstream bug is confirmed fixed in 2.12.0) or used as a reason to revert this bump. Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[Dependabot bumps kamal 2.11.0 → 2.12.0] --> B[Gemfile version updated]
B --> C{Stale pin comment\nstill present?}
C -- Yes --> D[Comment claims 2.12.0 has\nErrno::ECONNRESET bug]
D --> E{Was bug fixed\nin 2.12.0?}
E -- Yes --> F[Remove stale comment]
E -- No --> G[Revert upgrade until\nbug is confirmed fixed]
C -- No --> H[Safe to merge]
B --> I[Gemfile.lock updated correctly]
B --> J[vendor/cache gem swapped]
%%{init: {'theme': 'base', 'themeVariables': {"darkMode": true, "background": "#0d1117", "primaryColor": "#21262d", "primaryTextColor": "#e6edf3", "primaryBorderColor": "#8b949e", "lineColor": "#8b949e", "textColor": "#e6edf3", "edgeLabelBackground": "#161b22", "actorBkg": "#21262d", "actorBorder": "#8b949e", "actorTextColor": "#e6edf3", "actorLineColor": "#8b949e", "signalColor": "#8b949e", "signalTextColor": "#e6edf3", "noteBkgColor": "#373320", "noteBorderColor": "#d4a72c", "noteTextColor": "#f0e6c0", "labelBoxBkgColor": "#21262d", "labelBoxBorderColor": "#8b949e", "labelTextColor": "#e6edf3", "loopTextColor": "#e6edf3", "activationBkgColor": "#30363d", "activationBorderColor": "#8b949e"}}}%%
flowchart TD
A[Dependabot bumps kamal 2.11.0 → 2.12.0] --> B[Gemfile version updated]
B --> C{Stale pin comment\nstill present?}
C -- Yes --> D[Comment claims 2.12.0 has\nErrno::ECONNRESET bug]
D --> E{Was bug fixed\nin 2.12.0?}
E -- Yes --> F[Remove stale comment]
E -- No --> G[Revert upgrade until\nbug is confirmed fixed]
C -- No --> H[Safe to merge]
B --> I[Gemfile.lock updated correctly]
B --> J[vendor/cache gem swapped]
Reviews (1): Last reviewed commit: "chore(deps-dev): bump kamal from 2.11.0 ..." | Re-trigger Greptile |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
| # Pinned to 2.11.0: 2.12.0 intermittently resets the second back-to-back | ||
| # `kamal app exec` SSH connection in the pre-deploy hook (Errno::ECONNRESET). | ||
| gem "kamal", "2.11.0", require: false | ||
| gem "kamal", "2.12.0", require: false |
There was a problem hiding this comment.
Errno::ECONNRESET bug. Now that the gem is 2.12.0, the comment either describes a live regression (if the bug wasn't fixed upstream) or is stale misleading documentation. Either the comment should be removed because the issue is resolved in 2.12.0, or this upgrade should be held until the upstream fix is confirmed.
| # Pinned to 2.11.0: 2.12.0 intermittently resets the second back-to-back | |
| # `kamal app exec` SSH connection in the pre-deploy hook (Errno::ECONNRESET). | |
| gem "kamal", "2.11.0", require: false | |
| gem "kamal", "2.12.0", require: false | |
| gem "kamal", "2.12.0", require: false |
Bumps kamal from 2.11.0 to 2.12.0.
Release notes
Sourced from kamal's releases.
Commits
bdefb89Bump version for 2.12.08eb9659Fix doc formatting for 2.12.0 release62579aaMerge pull request #1844 from matthewbjones/lock-waitdef0eaeAdd--lock-waitto retry deploy lock acquisitionbf22a93Expect git gc --auto step in push resetting clone test24d3dbbMerge pull request #1795 from leonvogt/kamal-secrets-path-defaultbd3e227Merge pull request #1833 from seeday/mainf2671a5Merge pull request #1860 from creadone/non-ascii-deploy-locke71bab5Merge pull request #1874 from basecamp/dependabot/bundler/bundler-f838d46215583beb8Merge pull request #1875 from basecamp/fix-aws-secrets-test-stubsDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)