fix(storefront): four requests shipped no body at all - #29
Merged
Merged
Conversation
Authenticate a Customer via SMS, Verify a SMS code, the creation-code request and Create a Customer all carried `content: ""`. Every one of them requires a body, so each failed on its own validation — and the published API reference showed no request body for endpoints that cannot work without one. That is a documentation gap as much as a contract failure. Each body is now the minimum the controller actually requires: login-with-sms phone verify-code identity + code request-creation-code mode (email|sms) + identity customers name + email + code The values reuse the variables the contract run already injects, so the seeded customer and its verification codes satisfy them. Create a review sent "content": "" and answered "The content field is required." It now carries real review text. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
pull Bot
pushed a commit
to danielabelski/fleetbase
that referenced
this pull request
Aug 11, 2026
The Storefront customer endpoints run the same flows as the FleetOps ones against the same seeded User, but scope their codes under their own `for` values, so the fleetops_* rows already seeded do not satisfy them. Three requests failed with "Unable to verify code." / "Invalid verification code provided!". Adds three rows, matched exactly as each controller looks them up: storefront_login ::verifyCode subject_uuid + code + for storefront_create_customer ::create code + for + meta->identity storefront_account_closure ::confirmClosure code + for + meta->identity Reuses the existing $seedVerificationCode helper, so they share the same code value and the same deterministic re-seeding on every run. Pairs with fleetbase/postman#29, which gives those requests a body to send. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Four Storefront requests carried
content: ""— an entirely empty body — for endpoints that cannot work without one. Each failed on its own validation, and the published API reference showed no request body at all for them. That is a documentation gap as much as a contract failure.Each body is now the minimum the controller actually requires:
login-with-smsphoneverify-codeidentity+coderequest-creation-codemode(email|sms) +identitycustomersname+email+codeThe values reuse variables the contract run already injects, so the seeded customer and its verification codes satisfy them (fleetbase/fleetbase#596).
Also:
Create a reviewsent"content": ""and answered "The content field is required." It now carries real review text.Verified each file parses and the rendered body is the intended JSON.
🤖 Generated with Claude Code