ci(api-contract): seed the storefront-scoped verification codes - #596
Merged
Merged
Conversation
The Storefront customer endpoints run the same flows as the FleetOps ones against the same seeded User, but scope their codes under their own `for` values, so the fleetops_* rows already seeded do not satisfy them. Three requests failed with "Unable to verify code." / "Invalid verification code provided!". Adds three rows, matched exactly as each controller looks them up: storefront_login ::verifyCode subject_uuid + code + for storefront_create_customer ::create code + for + meta->identity storefront_account_closure ::confirmClosure code + for + meta->identity Reuses the existing $seedVerificationCode helper, so they share the same code value and the same deterministic re-seeding on every run. Pairs with fleetbase/postman#29, which gives those requests a body to send. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #596 +/- ##
=========================================
Coverage 69.26% 69.26%
Complexity 22 22
=========================================
Files 176 176
Lines 3153 3153
=========================================
Hits 2184 2184
Misses 969 969
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Storefront customer endpoints run the same flows as the FleetOps ones, against the same seeded User — but they scope their codes under their own
forvalues, so thefleetops_*rows already seeded do not satisfy them. Three requests failed withUnable to verify code./Invalid verification code provided!.Adds three rows, matched exactly as each controller looks them up:
forstorefront_loginsubject_uuid+code+forstorefront_create_customercode+for+meta->identitystorefront_account_closurecode+for+meta->identityReuses the existing
$seedVerificationCodehelper, so they share the same code value and the same deterministic re-seeding on every run.Pairs with fleetbase/postman#29 — those requests currently ship an entirely empty body, so both halves are needed.
🤖 Generated with Claude Code