Skip to content

refactor: drop redundant database index #2476

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
krille-chan wants to merge 1 commit into
base: main
Choose a base branch
from
Open

refactor: drop redundant database index #2476

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion lib/src/database/sqflite_box.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,9 @@ class BoxCollection with ZoneTransactionMixin {
batch.execute(
'CREATE TABLE IF NOT EXISTS $name (k TEXT PRIMARY KEY NOT NULL, v TEXT)',
);
batch.execute('CREATE INDEX IF NOT EXISTS k_index ON $name (k)');
batch.execute(
'DROP INDEX IF EXISTS k_index',
); // Previously we have created a redundant index. We can safely remove it.
Comment thread
krille-chan marked this conversation as resolved.
}
await batch.commit(noResult: true);
return BoxCollection(sqfliteDatabase, boxNames, name);
Expand Down
Loading