Skip to content

refactor: drop redundant database index - #2476

Open
krille-chan wants to merge 1 commit into
mainfrom
krille/drop-redundant-index
Open

refactor: drop redundant database index#2476
krille-chan wants to merge 1 commit into
mainfrom
krille/drop-redundant-index

Conversation

@krille-chan

@krille-chan krille-chan commented Sep 5, 2026

Copy link
Copy Markdown
Contributor

The k_index we created here was actually never used and just duplicated the key which blows up the database without any benefit. We can safely drop it to decrease database size.#

Have tested it on macOS native and FluffyChat on Android and everything still seems to work fine. But it also doesn't decrease the database size actually. However we still don't need this index so we should remove it

The k_index we created here was
actually never used and just duplicated
the key which blows up the database
without any benefit. We can safely
drop it to decrease database size.
@krille-chan
krille-chan marked this pull request as ready for review September 5, 2026 14:07

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Want fixes drafted automatically? Bugbot Autofix can create code changes for findings. A team admin can enable Autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 827cf91. Configure here.

Comment thread lib/src/database/sqflite_box.dart
@codecov

codecov Bot commented Sep 5, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 60.38%. Comparing base (474c4d9) to head (827cf91).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2476   +/-   ##
=======================================
  Coverage   60.38%   60.38%           
=======================================
  Files         162      162           
  Lines       20564    20564           
=======================================
  Hits        12418    12418           
  Misses       8146     8146           
Files with missing lines Coverage Δ
lib/src/database/sqflite_box.dart 81.25% <100.00%> (ø)

Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 474c4d9...827cf91. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant