fix: Add ament_add_default_options to make package compatible with ROS 2 Humble#10
Open
TannerGilbert wants to merge 1 commit intoethz-asl:ros2from
Open
fix: Add ament_add_default_options to make package compatible with ROS 2 Humble#10TannerGilbert wants to merge 1 commit intoethz-asl:ros2from
TannerGilbert wants to merge 1 commit intoethz-asl:ros2from
Conversation
…S 2 Humble Signed-off-by: gilbertta <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currenlty
ament_add_default_optionsis only available in the master branch of ament_cmake (ament/ament_cmake#390). A backport PR to ROS 2 Humble already exists here ament/ament_cmake#418 but until it's merged this change is needed to support Humble and all other ROS 2 versions that don't rely on the master branch.