-
Notifications
You must be signed in to change notification settings - Fork 28
prgenv-gnu with ROCm 7 #273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
msimberg
wants to merge
58
commits into
eth-cscs:main
Choose a base branch
from
msimberg:prgenv-gnu-rocm-7
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
58 commits
Select commit
Hold shift + click to select a range
0d1a2a8
Add rccl and rccl-tests to rocm uenv
msimberg be76c7f
Disable duplicates strategy for now
msimberg c58f3bd
Verify that we can't concretize with one cray-mpich
msimberg fe92e52
Merge remote-tracking branch 'origin/main' into prgenv-gnu-rocm-rccl-…
msimberg 161e5e4
Enable duplicates:strategy:full again
msimberg bc2d134
Add prgenv-gnu rocm 7.0.2 uenv
msimberg 9126f90
Update spack-packages
msimberg 565dda6
Temporarily disable rocprofiler-systems
msimberg 54f4b3a
Merge remote-tracking branch 'origin/main' into prgenv-gnu-rocm-7
msimberg 4a7989e
Disable hipblaslt for now
msimberg c40da6f
Fix linaro forge config
msimberg 47ff00f
Disable tensile temporarily
msimberg 023d28e
Apply suggestion from @msimberg
msimberg de8e342
Try ROCm 7.1.0 from spack PR
iomaganaris cb127d1
Trying to fix hipblaslt
iomaganaris 63cb72f
Fix 7.1.0 hipblaslt
iomaganaris 71a0efb
Fix compiler version in yml file
iomaganaris ca3cd15
New try with fixes of clang-offload-bunder
iomaganaris 7df04a7
Disable all the rocprofiler related packages
iomaganaris 01633bc
Add unwind dependency to rocprofiler-register and use python 3.12.12 …
iomaganaris fccb073
cray-mpich@8.1.33
simonpintarelli 8182e42
cray-mpich@8.1.33 in rccl-test dependencies
simonpintarelli 069636e
Trying to enable rocprofiler-compute and -systems
iomaganaris d98ce89
Update py-dash recipe
iomaganaris 5fa76aa
Trying to install all the profilers and fix issue with hipsparse not …
iomaganaris b78552e
Expose hsa-rocr-dev package and add miopen-hip
iomaganaris c4df8f7
Increase build CI timelimit
iomaganaris 919305b
Try building hipsparse as static library to avoid issues in cupy
iomaganaris 7e1a261
Trying to fix LD_PRELOAD use in rocprofiler-compute
iomaganaris 2520ec1
Try to fix patch paths
iomaganaris a5ca1d5
Fix patch
iomaganaris 7dc8f93
Add rocprof-trace-decoder library to rocprof-systems
iomaganaris ccb8410
Try fixing issue with rocsparse missing symbols in hipsparse
iomaganaris fcc19af
Enable trace decoder library
iomaganaris 9efe30c
Fix trace decoder library path
iomaganaris 386294f
Add the rocprof-trace-decoder package to the environment.yaml file to…
iomaganaris 89f75bb
Merge remote-tracking branch 'origin/main' into prgenv-gnu-rocm-7
iomaganaris 11f640e
Revert changes regarding the timeout
iomaganaris 3973c92
Revert cray-mpich related changes
iomaganaris 4a0ed6c
Renamed 25.12 to 7.1.0
iomaganaris f469554
Update recipes/prgenv-gnu/7.1.0/amdgpu/environments.yaml
msimberg 4717a64
Update recipes/prgenv-gnu/7.1.0/amdgpu/environments.yaml
msimberg c1ae96d
Update recipes/prgenv-gnu/7.1.0/amdgpu/environments.yaml
msimberg 9fbc379
Update recipes/prgenv-gnu/7.1.0/amdgpu/environments.yaml
msimberg aec1617
Update recipes/prgenv-gnu/7.1.0/amdgpu/environments.yaml
msimberg 5b990c6
Update recipes/prgenv-gnu/7.1.0/amdgpu/environments.yaml
msimberg 2156847
Update recipes/prgenv-gnu/7.1.0/amdgpu/repo/packages/hipsparse/packag…
msimberg cfae521
Update recipes/prgenv-gnu/7.1.0/amdgpu/environments.yaml
msimberg a9fdeac
Update recipes/prgenv-gnu/7.1.0/amdgpu/config.yaml
msimberg bb1cc13
Update recipes/prgenv-gnu/7.1.0/amdgpu/environments.yaml
msimberg 1e67647
Update recipes/prgenv-gnu/7.1.0/amdgpu/environments.yaml
msimberg 8a88033
Update recipes/prgenv-gnu/7.1.0/amdgpu/config.yaml
msimberg cbb4763
Update recipes/prgenv-gnu/7.1.0/amdgpu/config.yaml
msimberg 4256458
Update recipes/prgenv-gnu/7.1.0/amdgpu/environments.yaml
msimberg 77145a1
Add netcdf and revert change to LD_PRELOAD to create usable uenv
iomaganaris 214056c
Disable LD_PRELOAD hack again
msimberg ae15f13
Use cray-mpich 9.1
msimberg 23edcd9
Apply suggestion from @msimberg
msimberg File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| gcc: | ||
| version: "13" | ||
| llvm-amdgpu: | ||
| version: "7.1.0" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| name: prgenv-gnu | ||
| version: 2 | ||
| spack: | ||
| commit: releases/v1.0 | ||
| repo: https://github.com/spack/spack.git | ||
| packages: | ||
| repo: https://github.com/msimberg/spack-packages.git | ||
| commit: aws-ofi-nccl-with-rocm-old-develop # develop on 2025-12-19 + https://github.com/spack/spack-packages/compare/develop...msimberg:spack-packages:aws-ofi-nccl-with-rocm-old-develop | ||
| description: GNU Compiler toolchain with cray-mpich, Python, CMake and other development tools for gfx90a, gfx942 (MI300A, MI250X) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,86 @@ | ||
| gcc-env: | ||
| compiler: [gcc, llvm-amdgpu] | ||
| network: | ||
| mpi: cray-mpich@9.1 +rocm | ||
| unify: when_possible | ||
| duplicates: | ||
| strategy: full | ||
| specs: | ||
| - boost +chrono +filesystem +iostreams +mpi +python +regex +serialization +shared +system +timer | ||
| - cmake | ||
| - fftw | ||
| - fmt | ||
| - gsl | ||
| - hdf5+cxx+hl+fortran+mpi | ||
| - netlib-scalapack | ||
| - lua | ||
| - libtree | ||
| - lz4 | ||
| - meson | ||
| - ninja | ||
| - openblas threads=openmp | ||
| - osu-micro-benchmarks ~xccl | ||
| - python@3 | ||
| - zlib-ng | ||
| - netcdf-c | ||
| - netcdf-cxx | ||
| - netcdf-cxx4 | ||
| - netcdf-fortran | ||
| # add GPU-specific packages here, for easier comparison with mc version | ||
| - hip@7.1.0 ^mesa@23.3.6 | ||
| - hipcub | ||
| - llvm-amdgpu | ||
| # rocm packages | ||
| - rocblas ^py-msgpack %cxx=gcc | ||
| - rocfft | ||
| - rocm-cmake %cxx=gcc | ||
| - rocm-openmp-extras | ||
| - rocm-core %cxx=gcc | ||
| - rocminfo | ||
| - rocprim | ||
| - rocprofiler-dev | ||
| - rocprofiler-sdk | ||
| - rocprof-trace-decoder | ||
| - rocprofiler-systems +internal-dyninst+internal-boost+trace-decoder | ||
| - rocprofiler-compute | ||
| - rocrand | ||
| - rocsolver | ||
| - rocsparse | ||
| - rocthrust | ||
| - roctracer-dev-api %cxx=gcc | ||
| - roctracer-dev | ||
| - rocm-gdb | ||
| - rocm-debug-agent | ||
| - hsa-rocr-dev | ||
| - comgr | ||
| # hip packages | ||
| - hipblas | ||
| - hipblaslt | ||
| - hiprand | ||
| - hipsparse~shared-libs | ||
| - hipfft | ||
| - hipblas-common | ||
| # - miopen-hip # TODO(iomaganaris): enable for julia AMD gpu build | ||
| # networking | ||
| - rccl | ||
| # commits pinned for reproducibility, not bugs; update when updating recipe | ||
| - aws-ofi-nccl@1.18.0 | ||
| - rccl-tests@git.6405c76e6826663bbb67bd40aeee8c70aa5d3094=develop %cxx=llvm-amdgpu ^cray-mpich +rocm %c,cxx,fortran=gcc | ||
| variants: | ||
| - +mpi | ||
| - +rocm | ||
| - amdgpu_target=gfx942,gfx90a | ||
| - amdgpu_target_sram_ecc=gfx942,gfx90a | ||
| - ^python@3.12.12 | ||
| views: | ||
| default: | ||
| link: roots | ||
| exclude: ["llvm"] | ||
| uenv: | ||
| add_compilers: true | ||
| prefix_paths: | ||
| LD_LIBRARY_PATH: [lib, lib64] | ||
| env_vars: | ||
| set: | ||
| - NCCL_NET_PLUGIN: "ofi" | ||
| - HSA_NO_SCRATCH_RECLAIM: "1" | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,16 @@ | ||
| default: | ||
| features: | ||
| - rocm | ||
| - mpi | ||
| - rccl | ||
| - rccl-tests | ||
| - openmp | ||
| - prgenv | ||
| - serial | ||
| - cray-mpich | ||
| - osu-micro-benchmarks | ||
| cc: mpicc | ||
| cxx: mpic++ | ||
| ftn: mpifort | ||
| views: | ||
| - default |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| modules: | ||
| # Paths to check when creating modules for all module sets | ||
| prefix_inspections: | ||
| bin: | ||
| - PATH | ||
| lib: | ||
| - LD_LIBRARY_PATH | ||
| lib64: | ||
| - LD_LIBRARY_PATH | ||
|
|
||
| default: | ||
| arch_folder: false | ||
| # Where to install modules | ||
| roots: | ||
| tcl: /user-environment/modules | ||
| tcl: | ||
| all: | ||
| autoload: none | ||
| hash_length: 0 | ||
| exclude_implicits: true | ||
| exclude: ['%gcc@7.5.0', 'gcc %gcc@7.5.0'] | ||
| projections: | ||
| all: '{name}/{version}' |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| #!/bin/bash | ||
|
|
||
| set -e | ||
|
|
||
| # remove offending environment variables | ||
| jq '.views["default"].env.values.scalar["HIPCC_LINK_FLAGS_APPEND"]|="" | .views["default"].env.values.scalar["HIPCC_COMPILE_FLAGS_APPEND"]|="" ' /user-environment/meta/env.json > /tmp/env.json | ||
| # copy file back to destination | ||
| cp /tmp/env.json /user-environment/meta/env.json |
53 changes: 53 additions & 0 deletions
53
recipes/prgenv-gnu/7.1.0/amdgpu/repo/packages/hipblaslt/0001-Set-LLVM-Path-6.3.Patch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,53 @@ | ||
| diff --git a/library/CMakeLists.txt b/library/CMakeLists.txt | ||
| index 865dcd9..0ca1815 100644 | ||
| --- a/library/CMakeLists.txt | ||
| +++ b/library/CMakeLists.txt | ||
| @@ -72,6 +72,7 @@ include(src/CMakeLists.txt) | ||
| # Create hipBLASLt library | ||
| add_library(hipblaslt ${hipblaslt_source} ${hipblaslt_headers_public}) | ||
| add_library(roc::hipblaslt ALIAS hipblaslt) | ||
| +target_include_directories( hipblaslt PRIVATE ${MSGPACK_DIR}/include ) | ||
|
|
||
| # Target compile definitions | ||
| if(NOT BUILD_CUDA) | ||
| @@ -154,7 +155,7 @@ if( LEGACY_HIPBLAS_DIRECT ) | ||
| ) | ||
| else() | ||
| target_include_directories(hipblaslt | ||
| - PUBLIC $<BUILD_INTERFACE:${HIPBLAS-COMMON_INCLUDE_DIRS}> | ||
| + PUBLIC ${HIPBLAS-COMMON_INCLUDE_DIRS} | ||
| ) | ||
| endif() | ||
|
|
||
| diff --git a/tensilelite/Tensile/Common.py b/tensilelite/Tensile/Common.py | ||
| index 6b5cdc8..9f28e46 100644 | ||
| --- a/tensilelite/Tensile/Common.py | ||
| +++ b/tensilelite/Tensile/Common.py | ||
| @@ -277,6 +277,8 @@ globalParameters["LazyLibraryLoading"] = False # Load library and code object fi | ||
| globalParameters["UseUserArgs"] = False | ||
|
|
||
| globalParameters["RotatingBufferSize"] = 0 # Size in MB | ||
| +globalParameters["LLVMPath"] = os.environ.get("LLVM_PATH") | ||
| +globalParameters["ROCmSMIPath"] = os.environ.get("ROCM_SMI_PATH") | ||
| globalParameters["RotatingMode"] = 0 # Default is 0, allocated in order A0B0C0D0..ANBNCNDN. 1 is in order A0 pad B0 pad .... AN pad BN pad. | ||
| # Mode 0 requires memcpy everytime when the problem changes to reset the data, but mode 1 doesn't. | ||
|
|
||
| @@ -1576,7 +1578,7 @@ def assignGlobalParameters( config ): | ||
| if os.name == "nt": | ||
| globalParameters["ROCmAgentEnumeratorPath"] = locateExe(globalParameters["ROCmBinPath"], "hipinfo.exe") | ||
| else: | ||
| - globalParameters["ROCmAgentEnumeratorPath"] = locateExe(globalParameters["ROCmBinPath"], "rocm_agent_enumerator") | ||
| + globalParameters["ROCmAgentEnumeratorPath"] = os.environ.get("ROCM_AGENT_ENUMERATOR_PATH") | ||
|
|
||
| if "CxxCompiler" in config: | ||
| globalParameters["CxxCompiler"] = config["CxxCompiler"] | ||
| @@ -1602,8 +1604,7 @@ def assignGlobalParameters( config ): | ||
| compiler = "clang++" if globalParameters["CxxCompiler"] == "hipcc" else "amdclang++" | ||
| globalParameters["AssemblerPath"] = locateExe(os.path.join(globalParameters["ROCmPath"], bin_path), compiler) | ||
|
|
||
| - globalParameters["ROCmSMIPath"] = locateExe(globalParameters["ROCmBinPath"], "rocm-smi") | ||
| - globalParameters["ROCmLdPath"] = locateExe(os.path.join(globalParameters["ROCmPath"], "llvm/bin"), "ld.lld") | ||
| + globalParameters["ROCmLdPath"] = locateExe(os.path.join(globalParameters["LLVMPath"], "bin"), "ld.lld") | ||
|
|
||
| globalParameters["ExtractKernelPath"] = locateExe(os.path.join(globalParameters["ROCmPath"], "hip/bin"), "extractkernel") | ||
|
|
88 changes: 88 additions & 0 deletions
88
...gpu/repo/packages/hipblaslt/0001-Set-LLVM_Path-Add-Hiblas-Include-to-CmakeLists-6.1.Patch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,88 @@ | ||
| From 085d965e11cda1830cf325e0d12db3faf61a94d0 Mon Sep 17 00:00:00 2001 | ||
| From: sreenivasa murthy kolam <sreenivasamurthy.kolam@amd.com> | ||
| Date: Thu, 23 May 2024 05:49:34 +0000 | ||
| Subject: [PATCH] Add hipblas include dir in CMakeLists.txt and Modify the LLVM | ||
| Path in the Tensile code for Spack | ||
|
|
||
| --- | ||
| clients/gtest/CMakeLists.txt | 1 + | ||
| library/CMakeLists.txt | 2 ++ | ||
| tensilelite/Tensile/Common.py | 7 ++++--- | ||
| tensilelite/Tensile/Ops/gen_assembly.sh | 2 +- | ||
| 4 files changed, 8 insertions(+), 4 deletions(-) | ||
|
|
||
| diff --git a/clients/gtest/CMakeLists.txt b/clients/gtest/CMakeLists.txt | ||
| index 825bdca..f817e12 100644 | ||
| --- a/clients/gtest/CMakeLists.txt | ||
| +++ b/clients/gtest/CMakeLists.txt | ||
| @@ -53,6 +53,7 @@ target_include_directories( hipblaslt-test | ||
| $<BUILD_INTERFACE:${BLAS_INCLUDE_DIR}> | ||
| $<BUILD_INTERFACE:${BLIS_INCLUDE_DIR}> # may be blank if not used | ||
| $<BUILD_INTERFACE:${GTEST_INCLUDE_DIRS}> | ||
| + $<BUILD_INTERFACE:${HIPBLAS_INCLUDE_DIRS}> | ||
| ) | ||
| message("BLIS_INCLUDE_DIR=" ${BLIS_INCLUDE_DIR}) | ||
| target_link_libraries( hipblaslt-test PRIVATE ${BLAS_LIBRARY} ${GTEST_BOTH_LIBRARIES} roc::hipblaslt ) | ||
| diff --git a/library/CMakeLists.txt b/library/CMakeLists.txt | ||
| index 3252da0..1b8d628 100644 | ||
| --- a/library/CMakeLists.txt | ||
| +++ b/library/CMakeLists.txt | ||
| @@ -72,6 +72,8 @@ include(src/CMakeLists.txt) | ||
| # Create hipBLASLt library | ||
| add_library(hipblaslt ${hipblaslt_source} ${hipblaslt_headers_public}) | ||
| add_library(roc::hipblaslt ALIAS hipblaslt) | ||
| +target_include_directories( hipblaslt PRIVATE ${HIPBLAS_INCLUDE_DIRS} ) | ||
| +target_include_directories( hipblaslt PRIVATE ${MSGPACK_DIR}/include ) | ||
|
|
||
| # Target compile definitions | ||
| if(NOT BUILD_CUDA) | ||
| diff --git a/tensilelite/Tensile/Common.py b/tensilelite/Tensile/Common.py | ||
| index 8ee6373..52d6a97 100644 | ||
| --- a/tensilelite/Tensile/Common.py | ||
| +++ b/tensilelite/Tensile/Common.py | ||
| @@ -273,6 +273,7 @@ globalParameters["LazyLibraryLoading"] = False # Load library and code object fi | ||
| globalParameters["UseUserArgs"] = False | ||
|
|
||
| globalParameters["RotatingBufferSize"] = 0 # Size in MB | ||
| +globalParameters["LLVMPath"] = os.environ.get("LLVM_PATH") | ||
|
|
||
| # Save a copy - since pytest doesn't re-run this initialization code and YAML files can override global settings - odd things can happen | ||
| defaultGlobalParameters = deepcopy(globalParameters) | ||
| @@ -1488,10 +1489,10 @@ def assignGlobalParameters( config ): | ||
| if os.name == "nt": | ||
| globalParameters["AssemblerPath"] = locateExe(globalParameters["ROCmBinPath"], "clang++.exe") | ||
| else: | ||
| - globalParameters["AssemblerPath"] = locateExe(os.path.join(globalParameters["ROCmPath"], "llvm/bin"), "clang++") | ||
| + globalParameters["AssemblerPath"] = locateExe(os.path.join(globalParameters["LLVMPath"], "bin"), "clang++") | ||
|
|
||
| globalParameters["ROCmSMIPath"] = locateExe(globalParameters["ROCmBinPath"], "rocm-smi") | ||
| - globalParameters["ROCmLdPath"] = locateExe(os.path.join(globalParameters["ROCmPath"], "llvm/bin"), "ld.lld") | ||
| + globalParameters["ROCmLdPath"] = locateExe(os.path.join(globalParameters["LLVMPath"], "bin"), "ld.lld") | ||
|
|
||
| globalParameters["ExtractKernelPath"] = locateExe(os.path.join(globalParameters["ROCmPath"], "hip/bin"), "extractkernel") | ||
|
|
||
| @@ -1501,7 +1502,7 @@ def assignGlobalParameters( config ): | ||
| if os.name == "nt": | ||
| globalParameters["ClangOffloadBundlerPath"] = locateExe(globalParameters["ROCmBinPath"], "clang-offload-bundler.exe") | ||
| else: | ||
| - globalParameters["ClangOffloadBundlerPath"] = locateExe(os.path.join(globalParameters["ROCmPath"], "llvm/bin"), "clang-offload-bundler") | ||
| + globalParameters["ClangOffloadBundlerPath"] = locateExe(os.path.join(globalParameters["LLVMPath"], "bin"), "clang-offload-bundler") | ||
|
|
||
| if "ROCmAgentEnumeratorPath" in config: | ||
| globalParameters["ROCmAgentEnumeratorPath"] = config["ROCmAgentEnumeratorPath"] | ||
| diff --git a/tensilelite/Tensile/Ops/gen_assembly.sh b/tensilelite/Tensile/Ops/gen_assembly.sh | ||
| index 230c446..9f7dc6d 100644 | ||
| --- a/tensilelite/Tensile/Ops/gen_assembly.sh | ||
| +++ b/tensilelite/Tensile/Ops/gen_assembly.sh | ||
| @@ -32,7 +32,7 @@ if ! [ -z ${ROCM_PATH+x} ]; then | ||
| rocm_path=${ROCM_PATH} | ||
| fi | ||
|
|
||
| -toolchain=${rocm_path}/llvm/bin/clang++ | ||
| +toolchain=${LLVM_PATH}/bin/clang++ | ||
|
|
||
| . ${venv}/bin/activate | ||
|
|
||
| -- | ||
| 2.39.3 | ||
|
|
22 changes: 22 additions & 0 deletions
22
recipes/prgenv-gnu/7.1.0/amdgpu/repo/packages/hipblaslt/0004-Set-rocm-smi-ld-path-7.0.patch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,22 @@ | ||
| diff --git a/tensilelite/Tensile/Common/GlobalParameters.py b/tensilelite/Tensile/Common/GlobalParameters.py | ||
| index 4cbf586..e2602b9 100644 | ||
| --- a/tensilelite/Tensile/Common/GlobalParameters.py | ||
| +++ b/tensilelite/Tensile/Common/GlobalParameters.py | ||
| @@ -552,7 +552,7 @@ def assignGlobalParameters(config, isaInfoMap: Dict[IsaVersion, IsaInfo]): | ||
|
|
||
| globalParameters["ROCmBinPath"] = os.path.join(globalParameters["ROCmPath"], "bin") | ||
| try: | ||
| - globalParameters["ROCmSMIPath"] = locateExe(globalParameters["ROCmBinPath"], "rocm-smi") | ||
| + globalParameters["ROCmSMIPath"] = os.environ.get("ROCM_SMI_PATH") | ||
| except OSError: | ||
| if os.name == "nt": | ||
| # rocm-smi is not presently supported on Windows so do not require it. | ||
| @@ -560,7 +560,7 @@ def assignGlobalParameters(config, isaInfoMap: Dict[IsaVersion, IsaInfo]): | ||
| else: | ||
| raise | ||
| globalParameters["ROCmLdPath"] = locateExe( | ||
| - os.path.join(globalParameters["ROCmPath"], "lib/llvm/bin"), | ||
| + os.environ.get("ROCM_LD_PATH"), | ||
| "ld.lld" if os.name != "nt" else "ld.lld.exe" | ||
| ) | ||
|
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see https://github.com/eth-cscs/alps-uenv/pull/299/files#r2912985599.