Skip to content

prgenv-gnu with ROCm 7#273

Open
msimberg wants to merge 58 commits into
eth-cscs:mainfrom
msimberg:prgenv-gnu-rocm-7
Open

prgenv-gnu with ROCm 7#273
msimberg wants to merge 58 commits into
eth-cscs:mainfrom
msimberg:prgenv-gnu-rocm-7

Conversation

@msimberg

@msimberg msimberg commented Nov 20, 2025

Copy link
Copy Markdown
Collaborator

No description provided.

@msimberg

Copy link
Copy Markdown
Collaborator Author

cscs-ci run alps;system=beverin;uarch=mi200;uenv=prgenv-gnu:25.12

@msimberg

Copy link
Copy Markdown
Collaborator Author

hsa-amd-aqlprofile had missing compiler dependencies: spack/spack-packages#2532.

@msimberg

Copy link
Copy Markdown
Collaborator Author

cscs-ci run alps;system=beverin;uarch=mi200;uenv=prgenv-gnu:25.12

@msimberg

Copy link
Copy Markdown
Collaborator Author

cscs-ci run alps;system=beverin;uarch=mi200;uenv=prgenv-gnu:25.12

@msimberg

Copy link
Copy Markdown
Collaborator Author

ROCm is a menace: https://gitlab.com/cscs-ci/ci-testing/webhook-ci/mirrors/551234120955960/1440398897047560/-/jobs/12201564988#L3724. hipblaslt seems to be picking up amdclang++ from the system... needs further investigation.

@msimberg

Copy link
Copy Markdown
Collaborator Author

cscs-ci run alps;system=beverin;uarch=mi200;uenv=prgenv-gnu:25.12

@msimberg

Copy link
Copy Markdown
Collaborator Author

cscs-ci run alps;system=beverin;uarch=mi200;uenv=prgenv-gnu:25.12

@msimberg

Copy link
Copy Markdown
Collaborator Author

cscs-ci run alps;system=beverin;uarch=mi200;uenv=prgenv-gnu:25.12

@jgphpc

jgphpc commented Nov 28, 2025

Copy link
Copy Markdown
Contributor

Hi,
Could you add rocprofiler_sdk/package.py to the recipe ? needed for linaro...

Comment thread recipes/prgenv-gnu/25.12/amdgpu/environments.yaml Outdated
@msimberg

Copy link
Copy Markdown
Collaborator Author

Hi, Could you add rocprofiler_sdk/package.py to the recipe ? needed for linaro...

I'll try it out, hopefully no bigger issues (though note that I have issues with other packages before this is usable unfortunately).

@msimberg

msimberg commented Dec 3, 2025

Copy link
Copy Markdown
Collaborator Author

spack/spack-packages#2287 to add rocm 7.1.0 is also currently open. It may help, it may make things worse... The PR description does mention a change to hipblaslt, which may change something.

@afzpatel

afzpatel commented Dec 3, 2025

Copy link
Copy Markdown

ROCm is a menace: https://gitlab.com/cscs-ci/ci-testing/webhook-ci/mirrors/551234120955960/1440398897047560/-/jobs/12201564988#L3724. hipblaslt seems to be picking up amdclang++ from the system... needs further investigation.

Yes, it looks like an older version of ROCm is installed on the system and it's choosing the incorrect version of amdclang++. I'll see if I can reproduce the issue and put in a fix.

@iomaganaris

Copy link
Copy Markdown
Collaborator

cscs-ci run alps;system=beverin;uarch=mi200;uenv=prgenv-gnu:25.12

@iomaganaris

Copy link
Copy Markdown
Collaborator

cscs-ci run alps;system=beverin;uarch=mi200;uenv=prgenv-gnu:25.12

Comment thread recipes/prgenv-gnu/7.1.0/amdgpu/environments.yaml Outdated
Comment thread recipes/prgenv-gnu/7.1.0/amdgpu/config.yaml Outdated
Comment thread recipes/prgenv-gnu/7.1.0/amdgpu/config.yaml Outdated
Comment thread recipes/prgenv-gnu/7.1.0/amdgpu/environments.yaml Outdated
Comment thread recipes/prgenv-gnu/7.1.0/amdgpu/environments.yaml Outdated
@iomaganaris iomaganaris dismissed their stale review March 10, 2026 10:34

We should fix the issue with the CI before merging this PR

Comment thread recipes/prgenv-gnu/7.1.0/amdgpu/config.yaml Outdated
uenv:
add_compilers: true
prefix_paths:
LD_LIBRARY_PATH: [lib, lib64]

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
LD_LIBRARY_PATH: [lib, lib64]
LD_LIBRARY_PATH: [lib, lib64]
env_vars:
set:
- NCCL_NET_PLUGIN: "ofi"
- HSA_NO_SCRATCH_RECLAIM: "1"

see https://github.com/eth-cscs/alps-uenv/pull/299/files#r2912985599.

@msimberg

Copy link
Copy Markdown
Collaborator Author

cscs-ci run alps;system=beverin;uarch=mi200;uenv=prgenv-gnu:7.1.0

@msimberg

Copy link
Copy Markdown
Collaborator Author

This build also seems to be working a lot better (similar to the vanilla mpich build in #299 (comment)) after removing the LD_PRELOAD, adding eth-cscs/alps-cluster-config#79, and updating aws-ofi-nccl, but not perfectly.

RCCL tests have slightly worse performance on mi200 but that's ok and we can update the references in cscs-reframe-tests.

HPL is still failing and I have no idea what's going on there.

@iomaganaris

Copy link
Copy Markdown
Collaborator

cscs-ci run alps;system=beverin;uarch=mi200;uenv=prgenv-gnu:7.1.0

@iomaganaris

Copy link
Copy Markdown
Collaborator

I reverted commenting out LD_PRELOAD because I need a new uenv with netcdf 🙈

@msimberg

Copy link
Copy Markdown
Collaborator Author

cscs-ci run alps;system=beverin;uarch=mi200;uenv=prgenv-gnu:7.1.0

@msimberg

Copy link
Copy Markdown
Collaborator Author

I reverted commenting out LD_PRELOAD because I need a new uenv with netcdf 🙈

No worries :P I commented it out again (but feel free to reenable it again if you need a new build). I updated the recipe to use the new cray-mpich 9.1 which should officially be meant for rocm 7 (thanks @simonpintarelli for updating it!).

Comment thread recipes/prgenv-gnu/7.1.0/amdgpu/config.yaml Outdated
@msimberg

Copy link
Copy Markdown
Collaborator Author

cscs-ci run alps;system=beverin;uarch=mi200;uenv=prgenv-gnu:7.1.0

1 similar comment
@msimberg

Copy link
Copy Markdown
Collaborator Author

cscs-ci run alps;system=beverin;uarch=mi200;uenv=prgenv-gnu:7.1.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants