-
Notifications
You must be signed in to change notification settings - Fork 599
Fix config regression around falsy experimental_features (None)
#19987
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
MadLittleMods
merged 4 commits into
release-v1.157
from
madlittlemods/19986-fix-none-type-experimental_features-config
Jul 22, 2026
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| Fix config regression around falsy `experimental_features` no longer being accepted. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,71 @@ | ||
| # | ||
| # This file is licensed under the Affero General Public License (AGPL) version 3. | ||
| # | ||
| # Copyright (C) 2026 Element Creations Ltd. | ||
| # | ||
| # This program is free software: you can redistribute it and/or modify | ||
| # it under the terms of the GNU Affero General Public License as | ||
| # published by the Free Software Foundation, either version 3 of the | ||
| # License, or (at your option) any later version. | ||
| # | ||
| # See the GNU Affero General Public License for more details: | ||
| # <https://www.gnu.org/licenses/agpl-3.0.html>. | ||
|
|
||
|
|
||
| import yaml | ||
| from parameterized import parameterized | ||
|
|
||
| from synapse.config._base import RootConfig | ||
| from synapse.config.experimental import ExperimentalConfig | ||
| from synapse.config.homeserver import HomeServerConfig | ||
| from synapse.types import JsonDict | ||
|
|
||
| from tests import unittest | ||
|
|
||
|
|
||
| class ExperimentalConfigTestCase(unittest.TestCase): | ||
| @parameterized.expand( | ||
| [ | ||
| [ | ||
| "single", | ||
| { | ||
| "experimental_features": { | ||
| "msc3575_enabled": True, | ||
| } | ||
| }, | ||
| ], | ||
| [ | ||
| "multi", | ||
| { | ||
| "experimental_features": { | ||
| "msc3575_enabled": True, | ||
| "msc3030_enabled": True, | ||
| } | ||
| }, | ||
| ], | ||
| # This has historically worked and this is being added as a regression test | ||
| ["none", {"experimental_features": None}], | ||
| ] | ||
| ) | ||
| def test_experimental_features_parsing( | ||
| self, test_description: str, config_values: JsonDict | ||
| ) -> None: | ||
| """ | ||
| Test the that `experimental_features` parses with these values | ||
| """ | ||
|
|
||
| _read_config(config_values) | ||
|
|
||
|
|
||
| def _read_config(config_values: JsonDict) -> None: | ||
| ExperimentalConfig(RootConfig()).read_config( | ||
| yaml.safe_load( | ||
| HomeServerConfig().generate_config( | ||
| config_dir_path="CONFDIR", | ||
| data_dir_path="/data_dir_path", | ||
| server_name="che.org", | ||
| ) | ||
| ) | ||
| | config_values, | ||
| allow_secrets_in_config=False, | ||
| ) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This matches what we already do:
synapse/synapse/config/experimental.py
Line 65 in 3622579