Fix config regression around falsy experimental_features (None) - #19987
Merged
MadLittleMods merged 4 commits intoJul 22, 2026
Merged
Conversation
MadLittleMods
commented
Jul 22, 2026
| self.max_delayed_events_per_user: int = config.get( | ||
| "experimental_features", {} | ||
| ).get("msc4140_max_delayed_events_per_user", 100) | ||
| experimental = config.get("experimental_features") or {} |
Contributor
Author
There was a problem hiding this comment.
This matches what we already do:
synapse/synapse/config/experimental.py
Line 65 in 3622579
MadLittleMods
commented
Jul 22, 2026
| @@ -0,0 +1 @@ | |||
| Stub changelog: Merge with #19539. | |||
Contributor
Author
There was a problem hiding this comment.
This is here so the CI runs but the plan is to remove it in favor of coalescing it with #19539
Contributor
There was a problem hiding this comment.
since it's going out in a point release, wouldn't it need its own bugfix entry?
Contributor
Author
There was a problem hiding this comment.
That makes sense 👍
reivilibre
approved these changes
Jul 22, 2026
MadLittleMods
deleted the
madlittlemods/19986-fix-none-type-experimental_features-config
branch
July 22, 2026 14:07
Contributor
Author
|
Thanks for the review @reivilibre 🦦 |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix config regression around falsy
experimental_features(None)Examples:
experimental_features:Fix #19986
Regressed in #19539
The plan is to create a patch release and ship this in
v1.157.1Dev notes
Pull Request Checklist
EventStoretoEventWorkerStore.".code blocks.